From: ojan@chromium.org Date: Wed, 23 Feb 2011 03:30:09 +0000 (+0000) Subject: 2011-02-21 Ojan Vafai X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=86e459e2a1287e2704db87eac82026b0b909cad5 2011-02-21 Ojan Vafai Reviewed by Adam Barth. [codereviewtool] remove patch fuzzing https://bugs.webkit.org/show_bug.cgi?id=54940 This code is buggy and not as necessary now that we include svn revision numbers in uploaded patches. * code-review.js: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79389 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog index 0746ba28cbde..53832bec676a 100644 --- a/Websites/bugs.webkit.org/ChangeLog +++ b/Websites/bugs.webkit.org/ChangeLog @@ -1,3 +1,15 @@ +2011-02-21 Ojan Vafai + + Reviewed by Adam Barth. + + [codereviewtool] remove patch fuzzing + https://bugs.webkit.org/show_bug.cgi?id=54940 + + This code is buggy and not as necessary now that we + include svn revision numbers in uploaded patches. + + * code-review.js: + 2011-02-21 Ojan Vafai Reviewed by Adam Barth. diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js index 00efb367459c..397a2487def8 100644 --- a/Websites/bugs.webkit.org/code-review.js +++ b/Websites/bugs.webkit.org/code-review.js @@ -915,21 +915,13 @@ var CODE_REVIEW_UNITTEST; } function hunkStartingLine(patched_file, context, prev_line, hunk_num) { - var PATCH_FUZZ = 2; var current_line = -1; var last_context_line = context[context.length - 1]; if (patched_file[prev_line] == last_context_line) current_line = prev_line + 1; else { - for (var i = prev_line - PATCH_FUZZ; i < prev_line + PATCH_FUZZ; i++) { - if (patched_file[i] == last_context_line) - current_line = i + 1; - } - - if (current_line == -1) { - console.log('Hunk #' + hunk_num + ' FAILED.'); - return -1; - } + console.log('Hunk #' + hunk_num + ' FAILED.'); + return -1; } // For paranoia sake, confirm the rest of the context matches;