From: ap Date: Sun, 1 Oct 2006 08:35:29 +0000 (+0000) Subject: Reviewed by Maciej and Darin. X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=796fc9fb2ea88fa15ef036d577def3064468b113 Reviewed by Maciej and Darin. http://bugzilla.opendarwin.org/show_bug.cgi?id=4372 JavaScript document.write page form does not submit in Safari Test: fast/forms/document-write.html * page/Frame.cpp: (WebCore::Frame::submitForm): Don't check for parsing(). git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 980373f8fbac..443606d3def4 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,13 @@ +2006-10-01 Alexey Proskuryakov + + Reviewed by Maciej and Darin. + + Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4372 + JavaScript document.write page form does not submit in Safari + + * fast/forms/document-write-expected.txt: Added. + * fast/forms/document-write.html: Added. + 2006-09-30 Alexey Proskuryakov Reviewed by Darin. diff --git a/LayoutTests/fast/forms/document-write-expected.txt b/LayoutTests/fast/forms/document-write-expected.txt new file mode 100644 index 000000000000..f35a8003852c --- /dev/null +++ b/LayoutTests/fast/forms/document-write-expected.txt @@ -0,0 +1,5 @@ +Test for bug 4372: JavaScript document.write page form does not submit in Safari if document.close is not called. + +SUCCESS + + diff --git a/LayoutTests/fast/forms/document-write.html b/LayoutTests/fast/forms/document-write.html new file mode 100644 index 000000000000..235467e643c4 --- /dev/null +++ b/LayoutTests/fast/forms/document-write.html @@ -0,0 +1,31 @@ + + + + + +

Test for bug 4372: +JavaScript document.write page form does not submit in Safari if document.close is not called.

FAILURE

+ + diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 094cea3c4e7f..eee50e5189ab 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,15 @@ +2006-10-01 Alexey Proskuryakov + + Reviewed by Maciej and Darin. + + http://bugzilla.opendarwin.org/show_bug.cgi?id=4372 + JavaScript document.write page form does not submit in Safari + + Test: fast/forms/document-write.html + + * page/Frame.cpp: + (WebCore::Frame::submitForm): Don't check for parsing(). + 2006-10-01 Alexey Proskuryakov Build fix. diff --git a/WebCore/page/Frame.cpp b/WebCore/page/Frame.cpp index 73561afb9608..eec78e8be1ef 100644 --- a/WebCore/page/Frame.cpp +++ b/WebCore/page/Frame.cpp @@ -1664,7 +1664,7 @@ void Frame::submitForm(const char *action, const String& url, const FormData& fo request.setContentType("Content-Type: " + contentType + "; boundary=" + boundary); } - if (d->m_doc->parsing() || d->m_runningScripts > 0) { + if (d->m_runningScripts > 0) { if (d->m_submitForm) return; d->m_submitForm = new FramePrivate::SubmitForm;