From: harrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu, 5 May 2005 17:01:07 +0000 (+0000)
Subject:         Reviewed by me.
X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=4daf790cd9640f8ee0f5002f0c25fb197e4767e8

    Reviewed by me.

        Restore fixed setEndingSelection.  Fixed method was ifdef'd out
        because change was at end of Tiger development, but method is
        unused.  You just can never be _too_ safe.

        * khtml/editing/htmlediting.cpp:
        (khtml::EditCommandPtr::setEndingSelection):


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index b10bc8b4f0ba..3782993e8fb4 100644
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,14 @@
+2005-05-05  David Harrison  <harrison@apple.com>
+
+        Reviewed by me.
+
+        Restore fixed setEndingSelection.  Fixed method was ifdef'd out
+        because change was at end of Tiger development, but method is
+        unused.  You just can never be _too_ safe.
+        
+        * khtml/editing/htmlediting.cpp:
+        (khtml::EditCommandPtr::setEndingSelection):
+
 2005-05-02  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Vicki.
diff --git a/WebCore/khtml/editing/htmlediting.cpp b/WebCore/khtml/editing/htmlediting.cpp
index c097d7d36961..eb5355f1a10f 100644
--- a/WebCore/khtml/editing/htmlediting.cpp
+++ b/WebCore/khtml/editing/htmlediting.cpp
@@ -363,16 +363,11 @@ void EditCommandPtr::setEndingSelection(const Selection &s) const
     get()->setEndingSelection(s);
 }
 
-#if 0
-// Implementation mistakenly used get()->setStartingSelection(), but it is
-// too late in Tiger to change, even though this method is unused.  Safest, then,
-// to fix but comment out until post-Tiger.
 void EditCommandPtr::setEndingSelection(const VisiblePosition &p) const
 {
     IF_IMPL_NULL_RETURN;
     get()->setEndingSelection(p);
 }
-#endif
 
 void EditCommandPtr::setEndingSelection(const Position &p, EAffinity affinity) const
 {