From: zandobersek@gmail.com Date: Mon, 29 Apr 2013 08:05:37 +0000 (+0000) Subject: [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=3603f24c33f7a7da54acfe768368565f4d0e80c6;ds=sidebyside [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders https://bugs.webkit.org/show_bug.cgi?id=115323 Reviewed by Philippe Normand. Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders. Its presence enforces linkers to output mangled symbols when reporting linking failures due to unresolved references. People trying to fix the build can then simply copy the printed mangled symbol into the symbols.filter file instead of doing a manual build or connecting to the builders to discover the mangled version of the missing symbol. * BuildSlaveSupport/gtk/daemontools-buildbot.conf: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149271 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf b/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf index 06af29f7b062..25e31abfccaa 100644 --- a/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf +++ b/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf @@ -39,6 +39,7 @@ ccache_path="/usr/lib/ccache" # Environment variables. Prefix them with "env_". # env_CFLAGS="-pipe" +env_COLLECT_NO_DEMANGLE="1" env_CXXFLAGS="-pipe" env_LDFLAGS="-no-install -no-fast-install" env_WEBKIT_TESTFONTS="/home/${buildbot_user}/testfonts" diff --git a/Tools/ChangeLog b/Tools/ChangeLog index c6e6cc772311..08cc6de31963 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,18 @@ +2013-04-29 Zan Dobersek + + [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders + https://bugs.webkit.org/show_bug.cgi?id=115323 + + Reviewed by Philippe Normand. + + Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders. + Its presence enforces linkers to output mangled symbols when reporting linking failures + due to unresolved references. People trying to fix the build can then simply copy + the printed mangled symbol into the symbols.filter file instead of doing a manual build + or connecting to the builders to discover the mangled version of the missing symbol. + + * BuildSlaveSupport/gtk/daemontools-buildbot.conf: + 2013-04-28 Zan Dobersek Remove Chromium code from Tools/BuildSlaveSupport