From: rniwa@webkit.org Date: Wed, 6 May 2015 21:50:11 +0000 (+0000) Subject: Perf dashboard treats Speedometer and JetStream as smaller is better X-Git-Url: https://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=2a7dc15a90687aa6e5dde43024ab3df64f36d664 Perf dashboard treats Speedometer and JetStream as smaller is better https://bugs.webkit.org/show_bug.cgi?id=144711 Reviewed by Chris Dumez. Added the support for "Score" metric. * public/js/helper-classes.js: (PerfTestRuns): * public/v2/data.js: (RunsData.unitFromMetricName): (RunsData.isSmallerBetter): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183890 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog index 8f88c0e2e453..6747c9bad9d1 100644 --- a/Websites/perf.webkit.org/ChangeLog +++ b/Websites/perf.webkit.org/ChangeLog @@ -1,3 +1,18 @@ +2015-05-06 Ryosuke Niwa + + Perf dashboard treats Speedometer and JetStream as smaller is better + https://bugs.webkit.org/show_bug.cgi?id=144711 + + Reviewed by Chris Dumez. + + Added the support for "Score" metric. + + * public/js/helper-classes.js: + (PerfTestRuns): + * public/v2/data.js: + (RunsData.unitFromMetricName): + (RunsData.isSmallerBetter): + 2015-04-23 Ryosuke Niwa Build fix after r183232. diff --git a/Websites/perf.webkit.org/public/js/helper-classes.js b/Websites/perf.webkit.org/public/js/helper-classes.js index c7de1e7dfba9..962ee163d6cd 100755 --- a/Websites/perf.webkit.org/public/js/helper-classes.js +++ b/Websites/perf.webkit.org/public/js/helper-classes.js @@ -161,7 +161,8 @@ function PerfTestRuns(metric, platform) { 'Time': 'ms', 'Malloc': 'B', 'Heap': 'B', - 'Allocations': 'B'}[suffix]; + 'Allocations': 'B', + 'Score': 'pt'}[suffix]; // We can't do this in PerfTestResult because all results for each metric need to share the same unit and the same scaling factor. function computeScalingFactorIfNeeded() { diff --git a/Websites/perf.webkit.org/public/v2/data.js b/Websites/perf.webkit.org/public/v2/data.js index 83a1badefcce..4f4f89156dd0 100755 --- a/Websites/perf.webkit.org/public/v2/data.js +++ b/Websites/perf.webkit.org/public/v2/data.js @@ -408,14 +408,15 @@ RunsData.unitFromMetricName = function (metricName) 'Time': 'ms', 'Malloc': 'bytes', 'Heap': 'bytes', - 'Allocations': 'bytes' + 'Allocations': 'bytes', + 'Score': 'pt', }[suffix]; return unit; } RunsData.isSmallerBetter = function (unit) { - return unit != 'fps' && unit != '/s'; + return unit != 'fps' && unit != '/s' && unit != 'pt'; } function TimeSeries(series)