The status of a A/B testing request always eventually becomes "Failed"

https://bugs.webkit.org/show_bug.cgi?id=141523

Reviewed by Andreas Kling.

The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
'failedIfNotCompleted' was sent by the buildbot sync'er.

Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.

* public/api/build-requests.php:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 78026b9b667dad44e3c9a497992d8bb0922f097a..3262f874a5ea8f2926ad5800bdb333f940e08c0b 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,18 @@
+2015-02-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        The status of a A/B testing request always eventually becomes "Failed"
+        https://bugs.webkit.org/show_bug.cgi?id=141523
+
+        Reviewed by Andreas Kling.
+
+        The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
+        'failedIfNotCompleted' was sent by the buildbot sync'er.
+
+        Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
+
+        * public/api/build-requests.php:
+        (main):
+
 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
 
         Unreviewed, remove empty directories.

diff --git a/Websites/perf.webkit.org/public/api/build-requests.php b/Websites/perf.webkit.org/public/api/build-requests.php
index 71ecbb17c35e690ab1b0d7fe7162d2f0d4cd4e98..71a9373371432f76da675237acd29c401b3ef5be 100644 (file)
--- a/Websites/perf.webkit.org/public/api/build-requests.php
+++ b/Websites/perf.webkit.org/public/api/build-requests.php
@@ -28,7 +28,7 @@ function main($path, $post_data) {
             $url = array_get($info, 'url');
             if ($status == 'failedIfNotCompleted') {
                 $db->query_and_get_affected_rows('UPDATE build_requests SET (request_status, request_url) = ($1, $2)
-                    WHERE request_id = $3 AND request_status != $1', array('failed', $url, $id));
+                    WHERE request_id = $3 AND request_status != $4', array('failed', $url, $id, 'completed'));
             } else {
                 if (!in_array($status, array('pending', 'scheduled', 'running', 'failed', 'completed'))) {
                     $db->rollback_transaction();