Reviewed by Beth.
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Mar 2008 03:40:59 +0000 (03:40 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 11 Mar 2008 03:40:59 +0000 (03:40 +0000)
        Hold off on initializing the frame to avoid the RenderView getting
        a null FrameView. This could potentially cause problems.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/svg/graphics/SVGImage.cpp

index c0d43af026792a4dec5cbe46d69313e09addaf99..5de1d009539e22087c2a1889dc425d4a4aa3bef6 100644 (file)
@@ -1,3 +1,13 @@
+2008-03-10  Andre Boule  <aboule@apple.com>
+
+        Reviewed by Beth.
+
+        Hold off on initializing the frame to avoid the RenderView getting 
+        a null FrameView. This could potentially cause problems.
+
+        * svg/graphics/SVGImage.cpp:
+        (WebCore::SVGImage::dataChanged):
+
 2008-03-10  Darin Adler  <darin@apple.com>
 
         - try to fix Qt build
index de868b7cc6e028d7b8cf1b9bdba84c7070555e38..723ab82db80d3aad821705753d8e2a4c85c5dec6 100644 (file)
@@ -193,10 +193,10 @@ bool SVGImage::dataChanged(bool allDataReceived)
         m_page->settings()->setJavaScriptEnabled(false);
 
         m_frame = new Frame(m_page.get(), 0, dummyFrameLoaderClient);
-        m_frame->init();
         m_frameView = new FrameView(m_frame.get());
         m_frameView->deref(); // FIXME: FrameView starts with a refcount of 1
         m_frame->setView(m_frameView.get());
+        m_frame->init();
         ResourceRequest fakeRequest(KURL(""));
         m_frame->loader()->load(fakeRequest); // Make sure the DocumentLoader is created
         m_frame->loader()->cancelContentPolicyCheck(); // cancel any policy checks