run-webkit-tests mis-counts totals when there are other crashes
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jan 2016 18:20:27 +0000 (18:20 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jan 2016 18:20:27 +0000 (18:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=152894
<rdar://problem/24098697>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.add): Do not update result counters for other crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@194768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index d52ca66..43e58e4 100644 (file)
@@ -1,3 +1,14 @@
+2016-01-08  Aakash Jain  <aakash_jain@apple.com>
+
+        run-webkit-tests mis-counts totals when there are other crashes
+        https://bugs.webkit.org/show_bug.cgi?id=152894
+        <rdar://problem/24098697>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/layout_tests/models/test_run_results.py:
+        (TestRunResults.add): Do not update result counters for other crashes.
+
 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 
         webkit-patch build-and-test should have an option to iterate over new tests
index a47f63b..f2eb073 100644 (file)
@@ -67,6 +67,8 @@ class TestRunResults(object):
     def add(self, test_result, expected, test_is_slow):
         self.tests_by_expectation[test_result.type].add(test_result.test_name)
         self.results_by_name[test_result.test_name] = test_result
+        if test_result.is_other_crash:
+            return
         if test_result.type != test_expectations.SKIP:
             self.all_results.append(test_result)
         self.remaining -= 1