Web Inspector: make WebInspector a bit more timeline friendly.
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Sep 2011 15:19:16 +0000 (15:19 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Sep 2011 15:19:16 +0000 (15:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=68534

I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.

Reviewed by Yury Semikhatsky.

* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/CodeGeneratorInspector.pm
Source/WebCore/inspector/front-end/TimelinePanel.js

index 018fc91b9527b67445fcf941b689e08231606ac0..dd9df5ef8732dfa03f7699d9984ed9562f04f074 100644 (file)
@@ -1,3 +1,18 @@
+2011-09-21  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: make WebInspector a bit more timeline friendly.
+        https://bugs.webkit.org/show_bug.cgi?id=68534
+
+        I found that the maximum captured stack frame depth tracked by timeline is not
+        very convenient because the average depth of call stack considerably more than five.
+        Another useful trick is console.timeStamp for all backend calls.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/CodeGeneratorInspector.pm:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
+
 2011-09-21  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 
         [Qt][WK2] Implement Download support in WebProcess
index f1f80b46cf086946333c393c678e415e099c7659..1dda980e444d6985b4bafb732aec3ba2c12f750e 100644 (file)
@@ -860,6 +860,7 @@ InspectorBackendStub.prototype = {
 
     sendMessageObjectToBackend: function(messageObject)
     {
+        console.timeStamp(messageObject.method);
         var message = JSON.stringify(messageObject);
         InspectorFrontendHost.sendMessageToBackend(message);
     },
index 34efd438bcf2d421f5c632fef9de14acf4647687..dd45a6527d1c9374d82fd92fdef92543e21ce09a 100644 (file)
@@ -347,7 +347,7 @@ WebInspector.TimelinePanel.prototype = {
             WebInspector.timelineManager.stop();
         else {
             this._clearPanel();
-            WebInspector.timelineManager.start();
+            WebInspector.timelineManager.start(30);
             WebInspector.userMetrics.TimelineStarted.record();
         }
         this.toggleTimelineButton.toggled = !this.toggleTimelineButton.toggled;