Reviewed by Tim H, landed by Anders.
authorandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Nov 2006 03:17:44 +0000 (03:17 +0000)
committerandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Nov 2006 03:17:44 +0000 (03:17 +0000)
        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
        REGRESSION: Shadow of file upload button is clipped

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
        height to keep from clipping in the shadow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/rendering/RenderFileUploadControl.cpp

index af5a3aadca2d29d4dabb462c46d169eeb7f38755..d21c7f81eb384a24560c61c8c239bafb834c6068 100644 (file)
@@ -1,3 +1,14 @@
+2006-11-02  Adam Roben  <aroben@apple.com>
+
+        Reviewed by Tim H, landed by Anders.
+
+        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
+        REGRESSION: Shadow of file upload button is clipped
+
+        * rendering/RenderFileUploadControl.cpp:
+        (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
+        height to keep from clipping in the shadow
+
 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
 
         Reviewed by Maciej, landed by Anders.
 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
 
         Reviewed by Maciej, landed by Anders.
index e657967e07c8f99bf860cecb24f23266316a9f6c..f6b3772941ac17efe44910a068e22ab8d329d244 100644 (file)
@@ -144,7 +144,7 @@ void RenderFileUploadControl::paintObject(PaintInfo& paintInfo, int tx, int ty)
     // Push a clip.
     if (paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseChildBlockBackgrounds) {
         IntRect clipRect(tx + borderLeft(), ty + borderTop(),
     // Push a clip.
     if (paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseChildBlockBackgrounds) {
         IntRect clipRect(tx + borderLeft(), ty + borderTop(),
-                         width() - borderLeft() - borderRight(), height() - borderBottom() - borderTop());
+                         width() - borderLeft() - borderRight(), height() - borderBottom() - borderTop() + buttonShadowHeight);
         if (clipRect.width() == 0 || clipRect.height() == 0)
             return;
         paintInfo.context->save();
         if (clipRect.width() == 0 || clipRect.height() == 0)
             return;
         paintInfo.context->save();