2007-12-30 Luca Bruno <lethalman88@gmail.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 30 Dec 2007 11:52:03 +0000 (11:52 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 30 Dec 2007 11:52:03 +0000 (11:52 +0000)
        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16099
        Crash in CURL for empty POST

        We have to set POST even when the data is empty, otherwise cURL will
        hang while waiting for a response.

        * platform/network/curl/ResourceHandleManager.cpp
        (ResourceHandleManager::setupPOST): allow empty POST

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/network/curl/ResourceHandleManager.cpp

index 68de1551b22eeef272e5f582974347aa87febeed..70eb75eb755f3f98d95cf0c7b4a2927bf43d1aff 100644 (file)
@@ -1,3 +1,16 @@
+2007-12-30  Luca Bruno  <lethalman88@gmail.com>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16099
+        Crash in CURL for empty POST
+
+        We have to set POST even when the data is empty, otherwise cURL will
+        hang while waiting for a response.
+
+        * platform/network/curl/ResourceHandleManager.cpp
+        (ResourceHandleManager::setupPOST): allow empty POST
+
 2007-12-29  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 
         Reviewed by Alp Toker.
index 4bbfd94757e29089a50ad202d89d183caea825eb..a314f02fbda1fc8fa6f7bcb82d6d13579a0c5159 100644 (file)
@@ -330,8 +330,7 @@ void ResourceHandleManager::setupPOST(ResourceHandle* job)
         break;
     }
 
-    if (post)
-        curl_easy_setopt(d->m_handle, CURLOPT_HTTPPOST, post);
+    curl_easy_setopt(d->m_handle, CURLOPT_HTTPPOST, post);
 }
 
 void ResourceHandleManager::add(ResourceHandle* job)