[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()

https://bugs.webkit.org/show_bug.cgi?id=81512

Source/WebKit/efl:

Add missing implementation markerTextForListItem to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::markerTextForListItem):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation markerTextForListItem to EFL's
LayoutTestController so that we can unskip related tests from
the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::markerTextForListItem): Implemented.

LayoutTests:

Unskip tests connected with markerTextForListItem().

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index f160be8..3a24608 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Unskip tests connected with markerTextForListItem().
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped:
+
 2012-03-19  Robert Hogan  <robert@webkit.org>
 
         Text should overflow when list item height set to 0

diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
index 8861c9d..5b7b979 100644 (file)
--- a/LayoutTests/platform/efl/Skipped
+++ b/LayoutTests/platform/efl/Skipped
@@ -684,27 +684,6 @@ http/tests/globalhistory/history-delegate-basic-visited-links.html
 # EFL's LayoutTestController does not implement callShouldCloseOnWebView
 fast/events/onbeforeunload-focused-iframe.html
 
-# EFL's LayoutTestController does not implement markerTextForListItem
-fast/lists/alpha-boundary-values.html
-fast/lists/alpha-list-wrap.html
-fast/lists/decimal-leading-zero.html
-fast/lists/li-values.html
-fast/lists/list-style-type-dynamic-change.html
-fast/lists/ol-nested-items-dynamic-insert.html
-fast/lists/ol-nested-items-dynamic-remove.html
-fast/lists/ol-nested-items.html
-fast/lists/ol-nested-list-dynamic-insert.html
-fast/lists/ol-nested-list-dynamic-remove.html
-fast/lists/ol-nested-list.html
-fast/lists/positioned-count-crash.html
-fast/lists/w3-css3-list-styles-alphabetic.html
-fast/lists/w3-css3-list-styles-fallback-style.html
-fast/lists/w3-css3-list-styles-numeric.html
-fast/lists/w3-css3-list-styles-symbolic.html
-fast/lists/w3-css3-lower-armenian.html
-fast/lists/w3-css3-upper-armenian.html
-fast/lists/w3-list-styles.html
-
 # EFL's LayoutTestController does not implement shadowPseudoId
 fullscreen/video-controls-override.html
 media/audio-delete-while-step-button-clicked.html

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index d79c6a7..fb9645b 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,5 +1,19 @@
 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Add missing implementation markerTextForListItem to EFL's 
+        DumpRenderTreeSupport.
+
+        Reviewed by Antonio Gomes.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::markerTextForListItem):
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
         [EFL] Implement LayoutTestController::setEditingBehavior
         https://bugs.webkit.org/show_bug.cgi?id=81124
 

diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
index d3c403f..222b6db 100644 (file)
--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
@@ -435,3 +435,13 @@ void DumpRenderTreeSupportEfl::setEditingBehavior(Evas_Object* ewkView, const ch
 
     corePage->settings()->setEditingBehaviorType(coreEditingBehavior);
 }
+
+String DumpRenderTreeSupportEfl::markerTextForListItem(JSContextRef context, JSValueRef nodeObject)
+{
+    JSC::ExecState* exec = toJS(context);
+    WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject));
+    if (!element)
+        return String();
+
+    return WebCore::markerTextForListItem(element);
+}

diff --git a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
index f092391..8177f5f 100644 (file)
--- a/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
+++ b/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
@@ -82,6 +82,7 @@ public:
 
     static void deliverAllMutationsIfNecessary();
     static void setEditingBehavior(Evas_Object* ewkView, const char* editingBehavior);
+    static String markerTextForListItem(JSContextRef, JSValueRef nodeObject);
 };
 
 #endif // DumpRenderTreeSupportEfl_h

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 655b7fc..16b57f9 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,5 +1,19 @@
 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Adding missing implementation markerTextForListItem to EFL's
+        LayoutTestController so that we can unskip related tests from
+        the skip list.
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::markerTextForListItem): Implemented.
+
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
         [EFL] Enable view mode media feature layout tests
         https://bugs.webkit.org/show_bug.cgi?id=81205
 

diff --git a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
index a7c8812..e99d61b 100644 (file)
--- a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
+++ b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
@@ -718,10 +718,14 @@ void LayoutTestController::setWebViewEditable(bool)
     ewk_frame_editable_set(browser->mainFrame(), EINA_TRUE);
 }
 
-JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef, JSValueRef) const
+JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef context, JSValueRef nodeObject) const
 {
-    notImplemented();
-    return 0;
+    String markerTextChar = DumpRenderTreeSupportEfl::markerTextForListItem(context, nodeObject);
+    if (markerTextChar.isEmpty())
+        return 0;
+
+    JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithUTF8CString(markerTextChar.utf8().data()));
+    return markerText;
 }
 
 void LayoutTestController::authenticateSession(JSStringRef, JSStringRef, JSStringRef)