[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 20:51:48 +0000 (20:51 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 Mar 2012 20:51:48 +0000 (20:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=81512

Source/WebKit/efl:

Add missing implementation markerTextForListItem to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::markerTextForListItem):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation markerTextForListItem to EFL's
LayoutTestController so that we can unskip related tests from
the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::markerTextForListItem): Implemented.

LayoutTests:

Unskip tests connected with markerTextForListItem().

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl/Skipped
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
Tools/ChangeLog
Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

index f160be80e9850e66222414513a73a9016e4d96e8..3a24608396f85c289a71accadd91181e47acbc22 100644 (file)
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Unskip tests connected with markerTextForListItem().
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped:
+
 2012-03-19  Robert Hogan  <robert@webkit.org>
 
         Text should overflow when list item height set to 0
index 8861c9df55ed1eb0e0161eb1d2d09493b8066f0a..5b7b97930db2b95a3ec80984b6badc7b1e9c0b05 100644 (file)
@@ -684,27 +684,6 @@ http/tests/globalhistory/history-delegate-basic-visited-links.html
 # EFL's LayoutTestController does not implement callShouldCloseOnWebView
 fast/events/onbeforeunload-focused-iframe.html
 
-# EFL's LayoutTestController does not implement markerTextForListItem
-fast/lists/alpha-boundary-values.html
-fast/lists/alpha-list-wrap.html
-fast/lists/decimal-leading-zero.html
-fast/lists/li-values.html
-fast/lists/list-style-type-dynamic-change.html
-fast/lists/ol-nested-items-dynamic-insert.html
-fast/lists/ol-nested-items-dynamic-remove.html
-fast/lists/ol-nested-items.html
-fast/lists/ol-nested-list-dynamic-insert.html
-fast/lists/ol-nested-list-dynamic-remove.html
-fast/lists/ol-nested-list.html
-fast/lists/positioned-count-crash.html
-fast/lists/w3-css3-list-styles-alphabetic.html
-fast/lists/w3-css3-list-styles-fallback-style.html
-fast/lists/w3-css3-list-styles-numeric.html
-fast/lists/w3-css3-list-styles-symbolic.html
-fast/lists/w3-css3-lower-armenian.html
-fast/lists/w3-css3-upper-armenian.html
-fast/lists/w3-list-styles.html
-
 # EFL's LayoutTestController does not implement shadowPseudoId
 fullscreen/video-controls-override.html
 media/audio-delete-while-step-button-clicked.html
index d79c6a707d8fef47ce67d061941d93c00db2b16b..fb9645b42648713fe0e8a83907e2ad75998b35ae 100644 (file)
@@ -1,3 +1,17 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Add missing implementation markerTextForListItem to EFL's 
+        DumpRenderTreeSupport.
+
+        Reviewed by Antonio Gomes.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::markerTextForListItem):
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
         [EFL] Implement LayoutTestController::setEditingBehavior
index d3c403fdad422b0b1568c8bf8e9c3fd5faa95ff0..222b6db0f7b237abde77557535a182010624451f 100644 (file)
@@ -435,3 +435,13 @@ void DumpRenderTreeSupportEfl::setEditingBehavior(Evas_Object* ewkView, const ch
 
     corePage->settings()->setEditingBehaviorType(coreEditingBehavior);
 }
+
+String DumpRenderTreeSupportEfl::markerTextForListItem(JSContextRef context, JSValueRef nodeObject)
+{
+    JSC::ExecState* exec = toJS(context);
+    WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject));
+    if (!element)
+        return String();
+
+    return WebCore::markerTextForListItem(element);
+}
index f092391ec35aeecf30db5162b401a5d8fd44d7e2..8177f5f014677d0ee0f8be0925efe1ec57f3c7e7 100644 (file)
@@ -82,6 +82,7 @@ public:
 
     static void deliverAllMutationsIfNecessary();
     static void setEditingBehavior(Evas_Object* ewkView, const char* editingBehavior);
+    static String markerTextForListItem(JSContextRef, JSValueRef nodeObject);
 };
 
 #endif // DumpRenderTreeSupportEfl_h
index 655b7fc8a239b20b5abee9051af9569941fb2b1d..16b57f9d19ff954b1edaac47701465558748feff 100644 (file)
@@ -1,3 +1,17 @@
+2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
+
+        [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
+        https://bugs.webkit.org/show_bug.cgi?id=81512
+
+        Adding missing implementation markerTextForListItem to EFL's
+        LayoutTestController so that we can unskip related tests from
+        the skip list.
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::markerTextForListItem): Implemented.
+
 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
         [EFL] Enable view mode media feature layout tests
index a7c88122e837d23f616033a66f23f4f5effda87b..e99d61bc11d832d8d774e8d6ef8b5d04a637faff 100644 (file)
@@ -718,10 +718,14 @@ void LayoutTestController::setWebViewEditable(bool)
     ewk_frame_editable_set(browser->mainFrame(), EINA_TRUE);
 }
 
-JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef, JSValueRef) const
+JSRetainPtr<JSStringRef> LayoutTestController::markerTextForListItem(JSContextRef context, JSValueRef nodeObject) const
 {
-    notImplemented();
-    return 0;
+    String markerTextChar = DumpRenderTreeSupportEfl::markerTextForListItem(context, nodeObject);
+    if (markerTextChar.isEmpty())
+        return 0;
+
+    JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithUTF8CString(markerTextChar.utf8().data()));
+    return markerText;
 }
 
 void LayoutTestController::authenticateSession(JSStringRef, JSStringRef, JSStringRef)