WebKit:
authorrjw <rjw@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Oct 2004 23:24:28 +0000 (23:24 +0000)
committerrjw <rjw@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Oct 2004 23:24:28 +0000 (23:24 +0000)
        Fixed <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy.

        Reviewed by Ken.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _transparentBackground]):
        (-[WebHTMLView _setTransparentBackground:]):
        (-[WebHTMLView drawRect:]):
        * WebView.subproj/WebHTMLViewInternal.h:
        * WebView.subproj/WebHTMLViewPrivate.h:

WebBrowser:
As part of fix <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy, we can no longer rely on WebHTMLView filling with transparency, so added additional flag to indicate that we should.

        * Debug/DebugUtilities.m:
        (-[BrowserDocument toggleTransparentWindow:]):
        * LocationChangeHandler.m:
Removed #define to prevent console spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView.subproj/WebHTMLView.m
WebKit/WebView.subproj/WebHTMLViewInternal.h
WebKit/WebView.subproj/WebHTMLViewPrivate.h

index 34efac770ee2c2f93e7fa44bb1e3c883a2405c94..d2565904db617a01ed4ee42cab94e0c11abe98bb 100644 (file)
@@ -1,3 +1,16 @@
+2004-10-12  Richard Williamson   <rjw@apple.com>
+
+        Fixed <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy.
+
+        Reviewed by Ken.
+
+        * WebView.subproj/WebHTMLView.m:
+        (-[WebHTMLView _transparentBackground]):
+        (-[WebHTMLView _setTransparentBackground:]):
+        (-[WebHTMLView drawRect:]):
+        * WebView.subproj/WebHTMLViewInternal.h:
+        * WebView.subproj/WebHTMLViewPrivate.h:
+
 2004-10-11  Chris Blumenberg  <cblu@apple.com>
 
        Fixed: <rdar://problem/3802039> 8A259: Can't use Grab services to grab selection from screen
index b81f1b166bfdd8a1fa9947a6c630bac74a2b6b3c..5b51990735b4b7e9fcf11d1e63508f79e26a8d42 100644 (file)
@@ -1268,6 +1268,16 @@ static WebHTMLView *lastHitView = nil;
 
 #endif
 
+- (BOOL)_transparentBackground
+{
+    return _private->transparentBackground;
+}
+
+- (void)_setTransparentBackground:(BOOL)f
+{
+    _private->transparentBackground = f;
+}
+
 @end
 
 @implementation NSView (WebHTMLViewFileInternal)
@@ -1973,7 +1983,7 @@ static WebHTMLView *lastHitView = nil;
             [textRendererFactoryIfCoalescing startCoalesceTextDrawing];
         }
 
-        if (![[self _webView] drawsBackground]) {
+        if (![self _transparentBackground]) {
             [[NSColor clearColor] set];
             NSRectFill (rect);
         }
index 5c72bc4b40872cdc1287a34a6a6f206be617e738..9b14bf11e91a50218ffa2cf791f282e5c96d3ad1 100644 (file)
@@ -51,6 +51,8 @@
     BOOL nextResponderDisabledOnce;
     
     WebTextCompleteController *compController;
+    
+    BOOL transparentBackground;
 }
 @end
 
index b8c129c9fddd86288ab7e56748a1c74ead905def..b64a2d9f7dfe0fbf7c0f67a606ce63af58d9ed56 100644 (file)
@@ -60,4 +60,7 @@
 - (BOOL)_isSelectionMisspelled;
 - (NSArray *)_guessesForMisspelledSelection;
 
+- (BOOL)_transparentBackground;
+- (void)_setTransparentBackground:(BOOL)f;
+
 @end