LayoutTests:

        Reviewed by Eric, landed by Maciej.

        * svg/custom/class-selector.svg: Added.

WebCore:

        Reviewed by Eric, landed by Maciej.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7627:
        SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black

        Fix this svg stylesheet to use strict-mode, as this makes sure
        class selecting is done correctly.

        * ksvg2/svg/SVGStyleElement.cpp:
        (SVGStyleElement::childrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 913ce6c0726eba346d22ee783bde244f845fc46d..f7b1a1713159bc437374818f93c0c8b386de0b48 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,9 @@
+2006-04-04  Rob Buis  <buis@kde.org>
+
+        Reviewed by Eric, landed by Maciej.
+
+        * svg/custom/class-selector.svg: Added.
+
 2006-04-04  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Anders.

diff --git a/LayoutTests/svg/custom/class-selector.svg b/LayoutTests/svg/custom/class-selector.svg
new file mode 100644 (file)
index 0000000..8572661
--- /dev/null
+++ b/LayoutTests/svg/custom/class-selector.svg
@@ -0,0 +1,9 @@
+<?xml version="1.0" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
+  "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg xmlns="http://www.w3.org/2000/svg" width="400" height="400">
+<style type="text/css"><![CDATA[
+.Foo { fill: green; stroke-width:2 }
+]]></style>
+<rect class="Foo" x="100" y="100" width="200" height="200"/>
+</svg>

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1a744df4d7c909be522a9b495baa0b91d2e696d0..392d34520e003046001366d98b3dc5ba59ee1b55 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2006-04-04  Rob Buis  <buis@kde.org>
+
+        Reviewed by Eric, landed by Maciej.
+
+        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7627:
+        SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black
+
+        Fix this svg stylesheet to use strict-mode, as this makes sure
+        class selecting is done correctly.
+
+        * ksvg2/svg/SVGStyleElement.cpp:
+        (SVGStyleElement::childrenChanged):
+
 2006-04-05  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by mjs

diff --git a/WebCore/ksvg2/svg/SVGStyleElement.cpp b/WebCore/ksvg2/svg/SVGStyleElement.cpp
index ff1229772dbe49da691ee90cff968ae3c0113055..b80e886488229b19684f91adaea7ee3ea619d426 100644 (file)
--- a/WebCore/ksvg2/svg/SVGStyleElement.cpp
+++ b/WebCore/ksvg2/svg/SVGStyleElement.cpp
@@ -102,7 +102,7 @@ void SVGStyleElement::childrenChanged()
         m_loading = true;
  
         m_sheet = new CSSStyleSheet(this);
-        m_sheet->parseString(textContent(), false);//!document()->inCompatMode());
+        m_sheet->parseString(textContent()); // SVG css is always parsed in strict mode
 
         MediaList *mediaList = new MediaList(m_sheet.get(), _media);
         m_sheet->setMedia(mediaList);