2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
authorap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Aug 2006 18:37:49 +0000 (18:37 +0000)
committerap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Aug 2006 18:37:49 +0000 (18:37 +0000)
        Reviewed by Tim Hatcher.

        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

WebCore:
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::systemFont):
        Remove annoying notImplemented() usage in systemFont()

WebKitTools:
        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in
        Qt's DumpRenderTree.

      * Scripts/run-webkit-tests:
        Use -expected-qt.txt etc.. output in run-webkit-test if isQt().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/qt/RenderThemeQt.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp
WebKitTools/Scripts/run-webkit-tests

index 0e98cea347de62b552ee451daa60b2af559d235d..ad6f70a7a26fda2c53fcc76e06bb6ba5b32dfac2 100644 (file)
@@ -1,3 +1,13 @@
+2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>
+
+        Reviewed by Tim Hatcher.
+        
+        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::systemFont):
+        Remove annoying notImplemented() usage in systemFont()
+
 2006-08-28  David Harrison  <harrison@apple.com>
 
         Reviewed by Darin.
index c4c097fa93ec28389d58bf8c224f38f5f575e3e0..ee38fe982b9325133d381fea6535d370ee022cba 100644 (file)
@@ -113,7 +113,7 @@ bool RenderThemeQt::controlSupportsTints(const RenderObject* o) const
 
 void RenderThemeQt::systemFont(int propId, FontDescription& fontDescription) const
 {
-    notImplemented();
+    // no-op
 }
 
 RenderPopupMenu* RenderThemeQt::createPopupMenu(RenderArena*, Document*, RenderMenuList*)
index 7120d05bf7dfa977c2cca08cd4ac6cdef24238e8..aac6417f81d051bde20538c9651e07aa3317c56a 100644 (file)
@@ -1,3 +1,16 @@
+2006-08-28  Nikolas Zimmermann  <zimmermann@kde.org>
+
+        Reviewed by Tim Hatcher.
+        
+        Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
+
+        * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
+        (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in
+        Qt's DumpRenderTree.
+
+      * Scripts/run-webkit-tests:
+        Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
+
 2006-08-28  Darin Adler  <darin@apple.com>
 
         Reviewed by Tim Hatcher.
index 4021fbcafcd6344ca1163ec95cd9770a5a1af600..c519c381692c36aa105225e9b805bb119e15f0f5 100644 (file)
@@ -118,7 +118,7 @@ void DumpRenderTree::checkLoaded()
             QApplication::exit();
         }
     } else
-        QTimer::singleShot(20, this, SLOT(checkLoaded()));
+        QTimer::singleShot(10, this, SLOT(checkLoaded()));
 }
 
 }
index 9c63f16f0acbb2056df805e2ddfda9a0d575e63d..57fa505bc1fb4496bef01777ade8995563414983 100755 (executable)
@@ -94,14 +94,22 @@ my $verbose = 0;
 my $expectedTag = "expected";
 if (isCygwin()) {
     $expectedTag = "expected-win";
+} elsif (isQt()) {
+    $expectedTag = "expected-qt";
 }
+
 my $actualTag = "actual";
 if (isCygwin()) {
     $actualTag = "actual-win";
+} elsif (isQt()) {
+    $actualTag = "actual-qt";
 }
+
 my $diffsTag = "diffs";
 if (isCygwin()) {
     $actualTag = "diffs-win";
+} elsif (isQt()) {
+    $actualTag = "diffs-qt";
 }
 
 my $usage =