Reviewed by Kevin.

        - fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series
        of authentication sheets

        * Panels.subproj/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel cancel:]):
        retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as:
        <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index e3341336f3c1a93052a0357eb65f02300686fb58..8c371e4ca55bc5cc5c840fd9dc9568c59892759d 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2005-05-13  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Kevin.
+        
+        - fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series 
+        of authentication sheets
+
+        * Panels.subproj/WebAuthenticationPanel.m:
+        (-[WebAuthenticationPanel cancel:]):
+        retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as:
+        <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down
+
 2005-05-12  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Kevin.

diff --git a/WebKit/Panels.subproj/WebAuthenticationPanel.m b/WebKit/Panels.subproj/WebAuthenticationPanel.m
index ef4f550879bfb65e807c1d6b0460e74740555c82..00a6dc47c43223c9019bbd31ea49558cbf530317 100644 (file)
--- a/WebKit/Panels.subproj/WebAuthenticationPanel.m
+++ b/WebKit/Panels.subproj/WebAuthenticationPanel.m
@@ -52,6 +52,9 @@
     // crash later when finishing button hit tracking.  So we make
     // sure it lives on a bit longer.
     [[panel retain] autorelease];
+    
+    // This is required as a workaround for AppKit issue 4118422
+    [[self retain] autorelease];
 
     [panel close];
     if (usingSheet) {