JSContext Inspector: Scripts sometimes do not show in resources tab

https://bugs.webkit.org/show_bug.cgi?id=175153
<rdar://problem/33708683>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-03
Reviewed by Matt Baker.

* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype.initialLayout):
When the ResourceSidebar is lazily created, be sure to add any scripts
to the sidebar that are not backed by Resources.

(WI.ResourceSidebarPanel.prototype._scriptWasAdded):
(WI.ResourceSidebarPanel.prototype._addScript):
Extract so it can be used outside of an event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index d2c236bc0281f8081e2c8b7d4172e5e3ee9e0184..66328743ecd2bb7905e61350f5952f592308e96e 100644 (file)
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,20 @@
+2017-08-03  Joseph Pecoraro  <pecoraro@apple.com>
+
+        JSContext Inspector: Scripts sometimes do not show in resources tab
+        https://bugs.webkit.org/show_bug.cgi?id=175153
+        <rdar://problem/33708683>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WI.ResourceSidebarPanel.prototype.initialLayout):
+        When the ResourceSidebar is lazily created, be sure to add any scripts
+        to the sidebar that are not backed by Resources.
+
+        (WI.ResourceSidebarPanel.prototype._scriptWasAdded):
+        (WI.ResourceSidebarPanel.prototype._addScript):
+        Extract so it can be used outside of an event handler.
+
 2017-08-03  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: add button to open Inspector^2

diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
index 42875b32fd656fc06cecace9156a39a90ef383cb..c03b04d55adc18b72fda499de93c086b3dbed805 100644 (file)
--- a/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js
@@ -201,6 +201,13 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSideba
 
         if (WI.frameResourceManager.mainFrame)
             this._mainFrameMainResourceDidChange(WI.frameResourceManager.mainFrame);
+
+        for (let script of WI.debuggerManager.knownNonResourceScripts) {
+            this._addScript(script);
+
+            if (script.sourceMaps.length && WI.debuggableType === WI.DebuggableType.JavaScript)
+                this.contentTreeOutline.disclosureButtons = true;
+        }
     }
 
     hasCustomFilters()
@@ -298,8 +305,11 @@ WI.ResourceSidebarPanel = class ResourceSidebarPanel extends WI.NavigationSideba
 
     _scriptWasAdded(event)
     {
-        var script = event.data.script;
+        this._addScript(event.data.script);
+    }
 
+    _addScript(script)
+    {
         // We don't add scripts without URLs here. Those scripts can quickly clutter the interface and
         // are usually more transient. They will get added if/when they need to be shown in a content view.
         if (!script.url && !script.sourceURL)