Reviewed by Vicki.

	<rdar://problem/3993557> REGRESSION (125-180-ish): getElementsByTagName no longer works with namespace designations

	* khtml/xml/dom_nodeimpl.cpp:
        (NodeBaseImpl::getElementsByTagNameNS): When no namespace is specified, find elements
	of the specified name in any namespace to match Mozilla and earlier Safari behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index ed45ffebe6a30d0051f64b0b65836f5209dd2dc4..4ca1a0b1f31ccf74ac69d2e4cc3922ccaa35192d 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,13 @@
+2005-02-27  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Vicki.
+
+       <rdar://problem/3993557> REGRESSION (125-180-ish): getElementsByTagName no longer works with namespace designations
+        
+       * khtml/xml/dom_nodeimpl.cpp:
+        (NodeBaseImpl::getElementsByTagNameNS): When no namespace is specified, find elements
+       of the specified name in any namespace to match Mozilla and earlier Safari behavior.
+
 2005-02-25  Darin Adler  <darin@apple.com>
 
         Reviewed by Adele.

diff --git a/WebCore/khtml/xml/dom_nodeimpl.cpp b/WebCore/khtml/xml/dom_nodeimpl.cpp
index a6cb04fe23a54dcb6f16dc01600100eedc0e9d65..11d501cd3940aecaf23b4782ce4ba647748a66af 100644 (file)
--- a/WebCore/khtml/xml/dom_nodeimpl.cpp
+++ b/WebCore/khtml/xml/dom_nodeimpl.cpp
@@ -2034,7 +2034,7 @@ NodeListImpl* NodeBaseImpl::getElementsByTagNameNS ( DOMStringImpl* namespaceURI
     NodeImpl::Id idMask = namespaceMask | localNameMask;
     if (localName->l && localName->s[0] == '*')
         idMask &= ~localNameMask;
-    if (namespaceURI && namespaceURI->l && namespaceURI->s[0] == '*')
+    if (!namespaceURI || (namespaceURI->l && namespaceURI->s[0] == '*'))
         idMask &= ~namespaceMask;
 
     Id id = 0; // 0 means "all items"