+2015-05-08 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r183945.
+ https://bugs.webkit.org/show_bug.cgi?id=144789
+
+ "It broke all the GTK+ tests" (Requested by KaL on #webkit).
+
+ Reverted changeset:
+
+ "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
+ https://bugs.webkit.org/show_bug.cgi?id=144746
+ http://trac.webkit.org/changeset/183945
+
2015-05-07 Myles C. Maxfield <mmaxfield@apple.com>
Cleanup after r183940
+2015-05-08 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r183945.
+ https://bugs.webkit.org/show_bug.cgi?id=144789
+
+ "It broke all the GTK+ tests" (Requested by KaL on #webkit).
+
+ Reverted changeset:
+
+ "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
+ https://bugs.webkit.org/show_bug.cgi?id=144746
+ http://trac.webkit.org/changeset/183945
+
2015-05-07 Chris Dumez <cdumez@apple.com>
Throttle RequestAnimationFrame in subframes that are outside the viewport
return gtk_widget_is_toplevel(widget) && GTK_IS_WINDOW(widget) && !GTK_IS_OFFSCREEN_WINDOW(widget);
}
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
static CString topLevelPath()
{
if (const char* topLevelDirectory = g_getenv("WEBKIT_TOP_LEVEL"))
IntPoint convertWidgetPointToScreenPoint(GtkWidget*, const IntPoint&);
bool widgetIsOnscreenToplevelWindow(GtkWidget*);
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
CString webkitBuildDirectory();
#endif
availableLocales.set(AtomicString(extractLocaleFromDictionaryFilePath(filePath)), filePath);
}
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
static void scanTestDictionariesDirectoryIfNecessary(HashMap<AtomicString, String>& availableLocales)
{
// It's unfortunate that we need to look for the dictionaries this way, but
for (size_t i = 0; i < WTF_ARRAY_LENGTH(gDictionaryDirectories); i++)
scanDirectoryForDicionaries(gDictionaryDirectories[i], availableLocales);
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
scanTestDictionariesDirectoryIfNecessary(availableLocales);
#endif
+2015-05-08 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r183945.
+ https://bugs.webkit.org/show_bug.cgi?id=144789
+
+ "It broke all the GTK+ tests" (Requested by KaL on #webkit).
+
+ Reverted changeset:
+
+ "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
+ https://bugs.webkit.org/show_bug.cgi?id=144746
+ http://trac.webkit.org/changeset/183945
+
2015-05-07 Conrad Shultz <conrad_shultz@apple.com>
Don't register for Lookup notifications until needed
#include <WebCore/FileSystem.h>
#include <glib.h>
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
#include <wtf/gobject/GlibUtilities.h>
#endif
namespace WebKit {
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
static String getExecutablePath()
{
CString executablePath = getCurrentExecutablePath();
static String findWebKitProcess(const char* processName)
{
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
static const char* execDirectory = g_getenv("WEBKIT_EXEC_PATH");
if (execDirectory) {
String processPath = pathByAppendingComponent(filenameToString(execDirectory), processName);
static const char* injectedBundleDirectory()
{
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
const char* bundleDirectory = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH");
if (bundleDirectory && g_file_test(bundleDirectory, G_FILE_TEST_IS_DIR))
return bundleDirectory;
{
static NeverDestroyed<WebCore::TextCheckerEnchant> checker;
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
// This is a bit of a hack, but ensures that for testing purposes,
// spell checking is properly initialized in WebKitTestRunner while
// running layout tests. We should consider replacing this with some
WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL ENABLE_VIDEO)
WEBKIT_OPTION_DEPEND(USE_GSTREAMER_MPEGTS ENABLE_VIDEO)
+# FIXME: There is no reason these should be different.
+SET_AND_EXPOSE_TO_BUILD(DEVELOPMENT_BUILD ${DEVELOPER_MODE})
if (DEVELOPER_MODE)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE ON)
+2015-05-08 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r183945.
+ https://bugs.webkit.org/show_bug.cgi?id=144789
+
+ "It broke all the GTK+ tests" (Requested by KaL on #webkit).
+
+ Reverted changeset:
+
+ "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
+ https://bugs.webkit.org/show_bug.cgi?id=144746
+ http://trac.webkit.org/changeset/183945
+
2015-05-07 Anders Carlsson <andersca@apple.com>
Build fixes.
int main(int argc, char *argv[])
{
gtk_init(&argc, &argv);
-#if defined(DEVELOPER_MODE)
+#if defined(DEVELOPMENT_BUILD)
g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif