Reviewed by mjs
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2006 00:00:24 +0000 (00:00 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2006 00:00:24 +0000 (00:00 +0000)
        I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
        so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
        implicit removes.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/editing/ReplaceSelectionCommand.cpp

index 70559b54d8b9c4e18bd2f9d463f402a989d99c20..1a744df4d7c909be522a9b495baa0b91d2e696d0 100644 (file)
@@ -1,3 +1,14 @@
+2006-04-05  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by mjs
+
+        I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
+        so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
+        implicit removes.
+
+        * editing/ReplaceSelectionCommand.cpp:
+        (WebCore::ReplaceSelectionCommand::doApply):
+
 2006-04-05  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Anders.
index f8987fdd5f966e57d5456501dc3feaee3f1880b1..41c98d0965e5c5aa25e1947ef300ff246b26af3b 100644 (file)
@@ -697,6 +697,7 @@ void ReplaceSelectionCommand::doApply()
         
         while (node) {
             Node *next = node->nextSibling();
+            fragment.removeNode(node);
             insertNodeAfterAndUpdateNodesInserted(node.get(), refNode.get());
             refNode = node;
             node = next;