The one word was typed by me, but only after debugging for a long time with...

        - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word

        * editing/TextIterator.cpp:
        (WebCore::WordAwareIterator::WordAwareIterator):
        We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
        in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
        kind RUNFINDER, so WordAwareIterator needs to do so also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 24fc6fc0f593db44ece63e561ff6e183ba89501a..640374df3f5a1e0b6f39f069184e11d1060066b9 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2007-01-17  John Sullivan  <sullivan@apple.com>
+
+        The one word was typed by me, but only after debugging for a long time with Darin.
+
+        - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
+
+        * editing/TextIterator.cpp:
+        (WebCore::WordAwareIterator::WordAwareIterator):
+        We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
+        in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
+        kind RUNFINDER, so WordAwareIterator needs to do so also.
+
 2007-01-17  Adele Peterson  <adele@apple.com>
 
         Reviewed by Brady.

diff --git a/WebCore/editing/TextIterator.cpp b/WebCore/editing/TextIterator.cpp
index 47fabbb4cef31859ad3770bf5d3ad81c3684cf4a..58ff7dc9256b2ddf299840db7e3b0ca51959019b 100644 (file)
--- a/WebCore/editing/TextIterator.cpp
+++ b/WebCore/editing/TextIterator.cpp
@@ -865,7 +865,7 @@ WordAwareIterator::WordAwareIterator()
 }
 
 WordAwareIterator::WordAwareIterator(const Range *r)
-: m_previousText(0), m_didLookAhead(false), m_textIterator(r)
+: m_previousText(0), m_didLookAhead(false), m_textIterator(r, RUNFINDER)
 {
     m_didLookAhead = true;  // so we consider the first chunk from the text iterator
     advance();              // get in position over the first chunk of text
@@ -878,7 +878,7 @@ WordAwareIterator::WordAwareIterator(const Range *r)
 //      (we looked ahead to the next chunk and found a word boundary)
 // - We built up our own chunk of text from many chunks from the text iterator
 
-//FIXME: Perf could be bad for huge spans next to each other that don't fall on word boundaries
+// FIXME: Perf could be bad for huge spans next to each other that don't fall on word boundaries
 
 void WordAwareIterator::advance()
 {