[Mac][WebKit2] Move action menu code into its own file
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Oct 2014 21:13:14 +0000 (21:13 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Oct 2014 21:13:14 +0000 (21:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138034
<rdar://problem/18758758>

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _addImageToPhotos:]):
Review comments that were not previously addressed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/mac/WKActionMenuController.mm

index 6552de281cb0b92927a1e97bc5089cd5a0d957a5..1fde491384337590f8773f4affcc5decc6909a59 100644 (file)
@@ -1,3 +1,14 @@
+2014-10-24  Tim Horton  <timothy_horton@apple.com>
+
+        [Mac][WebKit2] Move action menu code into its own file
+        https://bugs.webkit.org/show_bug.cgi?id=138034
+        <rdar://problem/18758758>
+
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController prepareForMenu:withEvent:]):
+        (-[WKActionMenuController _addImageToPhotos:]):
+        Review comments that were not previously addressed.
+
 2014-10-24  Tim Horton  <timothy_horton@apple.com>
 
         [Mac][WebKit2] Move action menu code into its own file
index a31f971eb9a683b3c03d86cbd2b9c5db167ece62..00d68e9bf9e137eb01fffe83b8ca77a42f26b2ea 100644 (file)
@@ -106,7 +106,7 @@ enum class ActionMenuState {
 
     [self _updateActionMenuItems];
 
-    _page->performActionMenuHitTestAtLocation([_wkView convertPoint:[event locationInWindow] fromView:nil]);
+    _page->performActionMenuHitTestAtLocation([_wkView convertPoint:event.locationInWindow fromView:nil]);
 
     _state = ActionMenuState::Pending;
 }
@@ -278,7 +278,7 @@ static NSString *pathToPhotoOnDisk(NSString *suggestedFilename)
 
 - (void)_addImageToPhotos:(id)sender
 {
-    // FIXME: We shouldn't even add the button if this is the case, for now.
+    // FIXME: We shouldn't even add the menu item if this is the case, for now.
     if (![getIKSlideshowClass() canExportToApplication:@"com.apple.Photos"])
         return;