Not reviewed.
authormjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Nov 2007 05:54:53 +0000 (05:54 +0000)
committermjs@apple.com <mjs@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Nov 2007 05:54:53 +0000 (05:54 +0000)
        Fix DumpRenderTree ObjC bug comparing strings.

        * DumpRenderTree/mac/ObjCController.m:
        (-[ObjCController identityIsEqual::]): Compare strings with string
        equality instead of identiy equality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/mac/ObjCController.m

index 3cdccc292023a474d518379df30d5c40d1a566cd..01911c5d4c0bce189ec3b7327960239942c874fb 100644 (file)
@@ -1,3 +1,13 @@
+2007-11-27  Maciej Stachowiak  <mjs@apple.com>
+
+        Not reviewed.
+
+        Fix DumpRenderTree ObjC bug comparing strings.
+
+        * DumpRenderTree/mac/ObjCController.m:
+        (-[ObjCController identityIsEqual::]): Compare strings with string
+        equality instead of identiy equality.
+
 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 
         Reviewed by Sam.
index b5f2c42879316001fe44fb816a04a45605596c79..1b9abb7b1ecd9f706b80f1756d7788d66fd31df5 100644 (file)
 
 - (BOOL)identityIsEqual:(WebScriptObject *)a :(WebScriptObject *)b
 {
+    if ([a isKindOfClass:[NSString class]] && [b isKindOfClass:[NSString class]])
+        return [(NSString *)a isEqualToString:(NSString *)b];
     return a == b;
 }