2011-02-01 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        avoid jitter when loading the comments to a patch
        https://bugs.webkit.org/show_bug.cgi?id=53570

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
index 9f01a70db4e59c1b24cab952b4658626fddca293..6dc492fd5dad79ef631c2dc61928afd11708a40a 100644 (file)
--- a/Websites/bugs.webkit.org/ChangeLog
+++ b/Websites/bugs.webkit.org/ChangeLog
@@ -1,3 +1,12 @@
+2011-02-01  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        avoid jitter when loading the comments to a patch
+        https://bugs.webkit.org/show_bug.cgi?id=53570
+
+        * code-review.js:
+
 2011-02-01  Ojan Vafai  <ojan@chromium.org>
 
         Reviewed by Mihai Parparita.

diff --git a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
index 553dded6e3dab637550ce8bb8623751f3e5282a9..ba109368ce129398b5277d4c5d258915825f0b64 100644 (file)
--- a/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
+++ b/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
@@ -417,7 +417,7 @@ body {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=31"></script>
+<script src="code-review.js?version=32"></script>
 EOF
 
     def self.revisionOrDescription(string)

diff --git a/Websites/bugs.webkit.org/code-review.js b/Websites/bugs.webkit.org/code-review.js
index d626d3ad650779195ce2656956a69c2228e27108..f5f4b449ebdf422579916b529d6c9a06b6a956b0 100644 (file)
--- a/Websites/bugs.webkit.org/code-review.js
+++ b/Websites/bugs.webkit.org/code-review.js
@@ -374,16 +374,14 @@ var CODE_REVIEW_UNITTEST;
       });
     }
 
-    var help_text = 'Scroll though diffs with the "j" and "k" keys.';
     if (comments.length == 0) {
-      $('#message .commentStatus').text(help_text);
       return;
     }
 
     descriptor = comments.length + ' comment';
     if (comments.length > 1)
       descriptor += 's';
-    $('#message .commentStatus').text('This patch has ' + descriptor + '.  Scroll through them with the "n" and "p" keys. ' + help_text);
+    $('.help').append(' This patch has ' + descriptor + '.  Scroll through them with the "n" and "p" keys.');
   }
 
   function scanForStyleQueueComments(text) {
@@ -997,10 +995,9 @@ var CODE_REVIEW_UNITTEST;
     crawlDiff();
     fetchHistory();
     $(document.body).prepend('<div id="message">' +
-        '<div class="help">Select line numbers to add a comment.' +
+        '<div class="help">Select line numbers to add a comment. Scroll though diffs with the "j" and "k" keys.' +
           '<div class="DiffLinks LinkContainer">' + diffLinksHtml() + '</div>' +
         '</div>' +
-        '<div class="commentStatus"></div>' +
         '</div>');
     $(document.body).append('<div id="toolbar">' +
         '<div class="overallComments">' +