Remove unworkable video-buffering-repaints-controls test.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Apr 2012 22:49:43 +0000 (22:49 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Apr 2012 22:49:43 +0000 (22:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=83097

.:

Replaces the automated test for progress bar repaints during buffering
with a manual test entry.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

* ManualTests/media-controls.html:

LayoutTests:

Test has been broken in one way or another for some time now. I've
approached multiple people about possible solutions, but nothing ends
up being stable.

After discussion with fischman and trying a couple more solutions
today, we decided the best course of action is to remove the test.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

* http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* http/tests/media/video-buffering-repaints-controls.html: Removed.
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt [deleted file]
LayoutTests/http/tests/media/video-buffering-repaints-controls.html [deleted file]
LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt [deleted file]
LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/platform/efl/Skipped
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png [deleted file]
LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt [deleted file]
LayoutTests/platform/mac/Skipped
LayoutTests/platform/mac/test_expectations.txt
ManualTests/media-controls.html

index e23a8593c41442c2dd7b207b33d1938de788557d..6128e116c33cecc09cea0e0ba0b9b0a35bfc06be 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2012-04-09  Dale Curtis  <dalecurtis@chromium.org>
+
+        Remove unworkable video-buffering-repaints-controls test.
+        https://bugs.webkit.org/show_bug.cgi?id=83097
+
+        Replaces the automated test for progress bar repaints during buffering
+        with a manual test entry.
+
+        Reviewed by Eric Carlson.
+
+        * ManualTests/media-controls.html:
+
 2012-04-09  Ming Xie  <mxie@rim.com>
 
         [BlackBerry] Allow simulator to use GLES2 acceleration
index d6d073a9c49cf32e4b41de8485aab7c7a2dff2d2..6bdb4682798ae014cd56a264a20f0e4e6df6b4b8 100644 (file)
@@ -1,3 +1,33 @@
+2012-04-09  Dale Curtis  <dalecurtis@chromium.org>
+
+        Remove unworkable video-buffering-repaints-controls test.
+        https://bugs.webkit.org/show_bug.cgi?id=83097
+
+        Test has been broken in one way or another for some time now. I've
+        approached multiple people about possible solutions, but nothing ends
+        up being stable.
+
+        After discussion with fischman and trying a couple more solutions
+        today, we decided the best course of action is to remove the test.
+
+        Reviewed by Eric Carlson.
+
+        * http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+        * http/tests/media/video-buffering-repaints-controls.html: Removed.
+        * platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+        * platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/chromium/test_expectations.txt:
+        * platform/efl/Skipped:
+        * platform/gtk/Skipped:
+        * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
+        * platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
+        * platform/mac/Skipped:
+        * platform/mac/test_expectations.txt:
+
 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r113613.
diff --git a/LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt b/LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt
deleted file mode 100644 (file)
index 917cf17..0000000
+++ /dev/null
@@ -1,4 +0,0 @@
-Test that media controls repaint correctly during paused states when new data is buffered.
-
-
-
diff --git a/LayoutTests/http/tests/media/video-buffering-repaints-controls.html b/LayoutTests/http/tests/media/video-buffering-repaints-controls.html
deleted file mode 100644 (file)
index 097cae6..0000000
+++ /dev/null
@@ -1,34 +0,0 @@
-<html>
-    <head>
-        <script src="../../media-resources/media-file.js"></script>
-        <script>
-            function start() {
-                if (window.layoutTestController) {
-                    layoutTestController.dumpAsText(true);
-                    layoutTestController.waitUntilDone();
-                }
-
-                var video = document.querySelector('video');
-
-                video.addEventListener('progress', function(event) {
-                    layoutTestController.display();
-                }, false);
-
-                video.addEventListener('suspend', function(event) {
-                    layoutTestController.notifyDone();
-                }, false);
-
-                var mediaFile = findMediaFile("video", "resources/test");
-                var mimeType = mimeTypeForFile(mediaFile);
-
-                // Don't actually play since we're testing via an image diff.
-                video.src = 'http://127.0.0.1:8000/media/video-throttled-load.cgi?&name=' + mediaFile + '&throttle=80&type=' + mimeType
-            }
-        </script>
-    </head>
-
-    <body onload="start();">
-        <p>Test that media controls repaint correctly during paused states when new data is buffered.</p>
-        <video controls preload></video><br/>
-    </body>
-</html>
diff --git a/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index 504e777..0000000
Binary files a/LayoutTests/platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index 5e47426..0000000
Binary files a/LayoutTests/platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index 541b18f..0000000
Binary files a/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt b/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
deleted file mode 100644 (file)
index 917cf17..0000000
+++ /dev/null
@@ -1,4 +0,0 @@
-Test that media controls repaint correctly during paused states when new data is buffered.
-
-
-
diff --git a/LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index 6854006..0000000
Binary files a/LayoutTests/platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index 70a238d..0000000
Binary files a/LayoutTests/platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
index 7e7d3d6833368bfc57f0bb550ffb786786911549..b23b879e062f3d179599bba68aec661b3faaf336 100644 (file)
@@ -3265,9 +3265,6 @@ BUGWK76280 : media/W3C/video/networkState/networkState_during_progress.html = PA
 BUGV81900 SLOW LINUX DEBUG : inspector/debugger/watch-expressions-panel-switch.html = PASS CRASH
 BUGV81900 SLOW LINUX DEBUG : inspector/debugger/debugger-breakpoints-not-activated-on-reload.html = PASS CRASH
 
-// New test, image results added but it is timing out on Leopard.
-BUGWK75570 WIN LINUX : http/tests/media/video-buffering-repaints-controls.html = IMAGE
-
 // New reftest failing on Win7.
 BUGWK76050 WIN7 : fast/text/font-kerning.html = IMAGE
 
index 6722f0b965da1c72c8ad47c0495c3ef81b79b3c2..e17b49d30c507abfc86cbe642b33cf298157ac28 100644 (file)
@@ -2404,7 +2404,6 @@ http/tests/loading/slow-parsing-subframe.html
 http/tests/loading/state-object-security-exception.html
 http/tests/media/remove-while-loading.html
 http/tests/media/video-buffered.html
-http/tests/media/video-buffering-repaints-controls.html
 http/tests/media/video-cancel-load.html
 http/tests/media/video-cookie.html
 http/tests/media/video-error-abort.html
index c72830a236869ac079be7a5af3dacaddd8b7b38a..6b2f4b286c701b497f84b4fee1bea265736e6eb0 100644 (file)
@@ -1526,9 +1526,6 @@ http/tests/download
 fast/events/clear-drag-state.html
 fast/events/clear-edit-drag-state.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=77019
-http/tests/media/video-buffering-repaints-controls.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=77413
 fast/parser/nested-fragment-parser-crash.html
 
diff --git a/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png b/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png
deleted file mode 100644 (file)
index fc39fb5..0000000
Binary files a/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png and /dev/null differ
diff --git a/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt b/LayoutTests/platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt
deleted file mode 100644 (file)
index c047ae4..0000000
+++ /dev/null
@@ -1,37 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {P} at (0,0) size 784x18
-        RenderText {#text} at (0,0) size 562x18
-          text run at (0,0) width 562: "Test that media controls repaint correctly during paused states when new data is buffered."
-      RenderBlock (anonymous) at (0,34) size 784x240
-        RenderBR {BR} at (320,240) size 0x0
-layer at (8,42) size 320x240
-  RenderVideo {VIDEO} at (0,0) size 320x240
-layer at (8,42) size 320x240
-  RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
-layer at (8,257) size 320x25
-  RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,215) size 320x25
-    RenderButton {INPUT} at (6,3) size 18x18
-    RenderButton {INPUT} at (32,4) size 16x16
-    RenderDeprecatedFlexibleBox {DIV} at (49,5) size 216x15
-      RenderSlider {INPUT} at (45,2) size 126x13
-        RenderDeprecatedFlexibleBox {DIV} at (0,0) size 126x13
-          RenderBlock {DIV} at (0,2) size 116x8
-          RenderBlock {DIV} at (116,2) size 10x8
-    RenderButton {INPUT} at (297,4) size 16x16
-    RenderButton {INPUT} at (267,6) size 14x12
-layer at (57,264) size 45x11
-  RenderDeprecatedFlexibleBox {DIV} at (0,2) size 45x11 [color=#FFFFFF]
-    RenderBlock (anonymous) at (9,0) size 26x11
-      RenderText {#text} at (0,0) size 26x11
-        text run at (0,0) width 26: "00:00"
-layer at (228,264) size 45x11
-  RenderDeprecatedFlexibleBox {DIV} at (171,2) size 45x11 [color=#FFFFFF]
-    RenderBlock (anonymous) at (7,0) size 31x11
-      RenderText {#text} at (0,0) size 31x11
-        text run at (0,0) width 31: "-00:06"
-layer at (102,266) size 10x8
-  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
index 5484a6e0ec7613d0d8c1dfb137eb00ce053b1e16..6b7fe41714970dc0910e98388b4cd62d0f3f685e 100644 (file)
@@ -611,7 +611,6 @@ canvas/philip/tests/2d.path.arc.scale.1.html
 
 # Media tests that time out unexpectedly
 # https://bugs.webkit.org/show_bug.cgi?id=81604
-http/tests/media/video-buffering-repaints-controls.html
 http/tests/media/video-useragent.html
 media/audio-garbage-collect.html
  
index 2749920437a34f9d6e0dd9f26e58cee8fbc7844b..97012ae365c853bb37705170f56235c815811518 100644 (file)
@@ -149,9 +149,6 @@ BUGWK74888 : fast/dom/HTMLTableElement/createCaption.html = TEXT
 BUGWK74888 : fast/repaint/table-section-repaint.html = TEXT
 BUGWK74888 : fast/table/frame-and-rules.html = TEXT
 
-// New test, needs image results added.
-BUGWK75570 : http/tests/media/video-buffering-repaints-controls.html = IMAGE
-
 // Rebaseline required after bug 74874
 BUGWK74874 : fast/table/027.html = TEXT
 BUGWK74874 : fast/table/027-vertical.html = TEXT
index 1837e59dd5e0370d50c03c63f41611e48e0ab4a2..e9df78ec86230947a34831c8c5a8dd5970f175aa 100644 (file)
@@ -192,6 +192,16 @@ var TESTS = {
     title: 'Audio with no source',
     description: 'Should have "Rewind" and "Play" buttons. Should not blink/twitch if reloaded.',
     html: '<audio controls></audio>'
+},
+'controls-buffer-update': {
+    title: 'Buffer progress bar updates',
+    description: '<p>The buffer progress bar should continue to update prior to video playback.</p>' +
+                 '<p>Verify the progress bar representing the amount of video buffered continues to ' +
+                 'update prior to video playback. Keep the mouse pointer off the progress bar during this check ' +
+                 'as movement over the control will trigger a repaint which invalidates the test.</p><p>' +
+                 'It\'s expected that the video may stop buffering before the entire video is loaded.</p>',
+    html: '<video controls src="http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_640x360.mov' +
+          '?prevent_caching=' + new Date().getTime() + '"></video>'
 }
 
 };