[GTK] REGRESSION: Kinetic scrolling on touchpad doesn't work with async scrolling off
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 15 May 2021 14:26:42 +0000 (14:26 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 15 May 2021 14:26:42 +0000 (14:26 +0000)
https://bugs.webkit.org/show_bug.cgi?id=224182

Patch by Alexander Mikhaylenko <alexm@gnome.org> on 2021-05-15
Reviewed by Michael Catanzaro.

Don't clear the scroll history every time we scroll, that defeats the whole point of having
the scroll history.

* platform/generic/ScrollAnimatorGeneric.cpp:
(WebCore::ScrollAnimatorGeneric::scrollToPositionWithoutAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@277539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/generic/ScrollAnimatorGeneric.cpp

index f14779e..476a4d6 100644 (file)
@@ -1,3 +1,16 @@
+2021-05-15  Alexander Mikhaylenko  <alexm@gnome.org>
+
+        [GTK] REGRESSION: Kinetic scrolling on touchpad doesn't work with async scrolling off
+        https://bugs.webkit.org/show_bug.cgi?id=224182
+
+        Reviewed by Michael Catanzaro.
+
+        Don't clear the scroll history every time we scroll, that defeats the whole point of having
+        the scroll history.
+
+        * platform/generic/ScrollAnimatorGeneric.cpp:
+        (WebCore::ScrollAnimatorGeneric::scrollToPositionWithoutAnimation):
+
 2021-05-15  Antti Koivisto  <antti@apple.com>
 
         Don't allow :visited link style in subtrees that use mix-blend-mode
index 268d2c9..890842d 100644 (file)
@@ -65,7 +65,6 @@ ScrollAnimatorGeneric::~ScrollAnimatorGeneric() = default;
 bool ScrollAnimatorGeneric::scrollToPositionWithoutAnimation(const FloatPoint& position, ScrollClamping clamping)
 {
     m_kineticAnimation->stop();
-    m_kineticAnimation->clearScrollHistory();
     return ScrollAnimator::scrollToPositionWithoutAnimation(position, clamping);
 }