Build fix after r190817. Now that pull-os-versions store fake timestamps, we need...
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Oct 2015 22:43:49 +0000 (22:43 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Oct 2015 22:43:49 +0000 (22:43 +0000)
checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
with a MismatchingCommitTime error.

* public/include/report-processor.php:
(ReportProcessor::resolve_build_id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/include/report-processor.php

index f4c93c5..4a97830 100644 (file)
@@ -1,3 +1,12 @@
+2015-10-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp
+        checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
+        with a MismatchingCommitTime error.
+
+        * public/include/report-processor.php:
+        (ReportProcessor::resolve_build_id):
+
 2015-10-08  Ryosuke Niwa  <rniwa@webkit.org>
 
         Perf dashboard erroneously shows an old OS build in A/B testing range
index d1d3a6a..cf6aea8 100644 (file)
@@ -152,7 +152,7 @@ class ReportProcessor {
                 array('repository' => $repository_id, 'revision' => $revision_data['revision']), $commit_data, '*');
             if (!$commit_row)
                 $this->exit_with_error('FailedToRecordCommit', $commit_data);
-            if (abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
+            if ($commit_data['time'] && abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
                 $this->exit_with_error('MismatchingCommitTime', array('existing' => $commit_row, 'new' => $commit_data));
 
             if (!$this->db->select_or_insert_row('build_commits', null,