Reviewed by Hyatt.
authorthatcher <thatcher@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Apr 2006 02:33:53 +0000 (02:33 +0000)
committerthatcher <thatcher@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Apr 2006 02:33:53 +0000 (02:33 +0000)
        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8352
          CSS text-shadow does not repaint completely when changed

        * manual-tests/dynamic-shadow.html: Added.
        * rendering/render_style.cpp:
        (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow
        changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/rendering/render_style.cpp

index 035a1b35b2377cdc33f00ed724ed9880a701f60e..03a2b87b0b17b98b3c09695ec4d2c11892b8097b 100644 (file)
@@ -1,3 +1,15 @@
+2006-04-19  Mitz Pettel  <opendarwin.org@mitzpettel.com>
+
+        Reviewed by Hyatt.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8352
+          CSS text-shadow does not repaint completely when changed
+
+        * manual-tests/dynamic-shadow.html: Added.
+        * rendering/render_style.cpp:
+        (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow
+        changes.
+
 2006-04-19  Adele Peterson  <adele@apple.com>
 
         Reviewed by Darin.
index 6cfa63090e381fd4bb7cf21295dbaf2632e057b8..9d52d044403a389727217f5cbcbd6670eb3cbb23 100644 (file)
@@ -815,7 +815,8 @@ RenderStyle::Diff RenderStyle::diff( const RenderStyle *other ) const
          !(inherited_flags._text_transform == other->inherited_flags._text_transform) ||
          !(inherited_flags._direction == other->inherited_flags._direction) ||
          !(inherited_flags._white_space == other->inherited_flags._white_space) ||
-         !(noninherited_flags._clear == other->noninherited_flags._clear)
+         !(noninherited_flags._clear == other->noninherited_flags._clear) ||
+         !css3InheritedData->shadowDataEquivalent(*other->css3InheritedData.get())
         )
         return Layout;
 
@@ -871,7 +872,6 @@ RenderStyle::Diff RenderStyle::diff( const RenderStyle *other ) const
         !(surround->border == other->surround->border) ||
         *background.get() != *other->background.get() ||
         visual->textDecoration != other->visual->textDecoration ||
-        !css3InheritedData->shadowDataEquivalent(*other->css3InheritedData.get()) ||
         css3InheritedData->userModify != other->css3InheritedData->userModify ||
         css3NonInheritedData->userSelect != other->css3NonInheritedData->userSelect ||
         css3NonInheritedData->userDrag != other->css3NonInheritedData->userDrag