Unreviewed, rolling out r220463.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Aug 2017 18:27:01 +0000 (18:27 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Aug 2017 18:27:01 +0000 (18:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
https://bugs.webkit.org/show_bug.cgi?id=175340
http://trac.webkit.org/changeset/220463

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/add-children-pseudo-element-expected.txt [deleted file]
LayoutTests/accessibility/add-children-pseudo-element.html [deleted file]
LayoutTests/accessibility/resources/svg-circle.svg [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlockFlow.cpp

index c75af9867cd8af68275f8ea0555c853c5d9167cc..26f83141c7aebadaaaab8dfebe71966052f3b1b5 100644 (file)
@@ -1,3 +1,18 @@
+2017-08-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r220463.
+        https://bugs.webkit.org/show_bug.cgi?id=175435
+
+        unaccepted fix (Requested by n_wang on #webkit).
+
+        Reverted changeset:
+
+        "AX: crash at
+        WebCore::AccessibilityObject::supportsARIALiveRegion() const +
+        24"
+        https://bugs.webkit.org/show_bug.cgi?id=175340
+        http://trac.webkit.org/changeset/220463
+
 2017-08-10  Ryan Haddad  <ryanhaddad@apple.com>
 
         Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
diff --git a/LayoutTests/accessibility/add-children-pseudo-element-expected.txt b/LayoutTests/accessibility/add-children-pseudo-element-expected.txt
deleted file mode 100644 (file)
index 81bca95..0000000
+++ /dev/null
@@ -1,12 +0,0 @@
-Language Email 
-Make sure that we are updating the render block flow element's children correctly.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS element.childrenCount is 3
-PASS element.childrenCount is 2
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/accessibility/add-children-pseudo-element.html b/LayoutTests/accessibility/add-children-pseudo-element.html
deleted file mode 100644 (file)
index 9ad8739..0000000
+++ /dev/null
@@ -1,70 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../resources/js-test-pre.js"></script>
-</head>
-
-<style>
-.pseudo::after {
-  content: url(resources/svg-circle.svg);
-  width: 18px;
-  height: 20px;
-  position: absolute;
-  margin-top: 6px;
-  right: 6px
-}
-
-.pseudo.hidden::after {
-    content: ' ';
-}
-</style>
-
-<body id="body">
-
-<div id="container">
-<div id="test" style="float : left;">
-<span>Language</span>
-<input id="test">
-</div>
-
-<div id="float" style="display: inline-block;" class="pseudo">
-<span required="" style="color: rgb(194, 0, 0);">Email</span>
-<input type="text" required="" aria-required="true" value="" onkeyup="hidePseudo();">
-</div>
-
-</div>
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
-
-    description("Make sure that we are updating the render block flow element's children correctly.");
-
-    if (window.accessibilityController) {
-        var element = accessibilityController.accessibleElementById("float");
-        shouldBe("element.childrenCount", "3");
-        
-        eventSender.keyDown('\t');
-        eventSender.keyDown('\t');
-        
-        shouldBe("element.childrenCount", "2");
-        showPseudo();
-        
-        function hidePseudo() {
-            document.getElementById("float").className += "hidden"
-        }
-        
-        function showPseudo() {
-            document.getElementById("float").className = "pseudo";
-        }
-                
-        // Make sure getting the attributes of its children won't cause crash
-        element.attributesOfChildren();
-    }
-
-</script>
-
-<script src="../resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/LayoutTests/accessibility/resources/svg-circle.svg b/LayoutTests/accessibility/resources/svg-circle.svg
deleted file mode 100644 (file)
index 1976976..0000000
+++ /dev/null
@@ -1,6 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg">
-     <g>
-        <text style="float:right"></text>
-        <text>circle</text>
-    </g>
-</svg>
\ No newline at end of file
index a3e7c9221829337597fb39f66cb4f26c9a4c6e66..cdb280a27627b2603f63b4b4203bf7ea1c1ea200 100644 (file)
@@ -1,3 +1,18 @@
+2017-08-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r220463.
+        https://bugs.webkit.org/show_bug.cgi?id=175435
+
+        unaccepted fix (Requested by n_wang on #webkit).
+
+        Reverted changeset:
+
+        "AX: crash at
+        WebCore::AccessibilityObject::supportsARIALiveRegion() const +
+        24"
+        https://bugs.webkit.org/show_bug.cgi?id=175340
+        http://trac.webkit.org/changeset/220463
+
 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         Remove ENABLE_GAMEPAD_DEPRECATED
index e5dec4eafbd8b36dab3e478236994ac0c5045425..3b287f809f14af7c0224713f5f122c679f3f9053 100644 (file)
@@ -24,7 +24,6 @@
 #include "config.h"
 #include "RenderBlockFlow.h"
 
-#include "AXObjectCache.h"
 #include "Editor.h"
 #include "FloatingObjects.h"
 #include "Frame.h"
@@ -2353,9 +2352,6 @@ FloatingObject* RenderBlockFlow::insertFloatingObject(RenderBox& floatBox)
     }
 
     setLogicalWidthForFloat(*floatingObject, logicalWidthForChild(floatBox) + marginStartForChild(floatBox) + marginEndForChild(floatBox));
-    
-    if (AXObjectCache* cache = document().existingAXObjectCache())
-        cache->childrenChanged(this);
 
     return m_floatingObjects->add(WTFMove(floatingObject));
 }
@@ -2393,9 +2389,6 @@ void RenderBlockFlow::removeFloatingObject(RenderBox& floatBox)
                 markLinesDirtyInBlockRange(0, logicalBottom);
             }
             m_floatingObjects->remove(&floatingObject);
-            
-            if (AXObjectCache* cache = document().existingAXObjectCache())
-                cache->childrenChanged(this);
         }
     }
 }