Teach webkitbot and WKR how to respond to yt?

https://bugs.webkit.org/show_bug.cgi?id=116775

Reviewed by Andreas Kling.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi): Fixed the usage string.
(Hi.execute): Made it more generic so that it works in WKR.
(YouThere): Added.
(YouThere.execute): Added.
* Scripts/webkitpy/tool/commands/newcommitbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 2bfa10e8b5316b39db111db7ca89e29dc002d288..1fae3099fe4b360019c7aa0b5fc82237c946f008 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,17 @@
+2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Teach webkitbot and WKR how to respond to yt?
+        https://bugs.webkit.org/show_bug.cgi?id=116775
+
+        Reviewed by Andreas Kling.
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        (Hi): Fixed the usage string.
+        (Hi.execute): Made it more generic so that it works in WKR.
+        (YouThere): Added.
+        (YouThere.execute): Added.
+        * Scripts/webkitpy/tool/commands/newcommitbot.py:
+
 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
 
         Try to fix the EFL build.

diff --git a/Tools/Scripts/webkitpy/tool/bot/irc_command.py b/Tools/Scripts/webkitpy/tool/bot/irc_command.py
index 00da84451790309ce9f257ca1705d39ad4d839e6..979fcff06b0fe682fa2dec93f3d1b5e3a47fb811 100644 (file)
--- a/Tools/Scripts/webkitpy/tool/bot/irc_command.py
+++ b/Tools/Scripts/webkitpy/tool/bot/irc_command.py
@@ -111,10 +111,10 @@ class Help(IRCCommand):
 
 class Hi(IRCCommand):
     usage_string = "hi"
-    help_string = "Retrieves a random quip from Bugzilla."
+    help_string = "Responds with hi."
 
     def execute(self, nick, args, tool, sheriff):
-        if len(args) and re.match(r'webkitbot_*\s*!\s*', ' '.join(args)):
+        if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
             return "%s: hi %s!" % (nick, nick)
         quips = tool.bugs.quips()
         quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
@@ -129,6 +129,14 @@ class PingPong(IRCCommand):
         return nick + ": pong"
 
 
+class YouThere(IRCCommand):
+    usage_string = "yt?"
+    help_string = "Responds with yes."
+
+    def execute(self, nick, args, tool, sheriff):
+        return "%s: yes" % nick
+
+
 class Restart(IRCCommand):
     usage_string = "restart"
     help_string = "Restarts sherrifbot.  Will update its WebKit checkout, and re-join the channel momentarily."
@@ -298,6 +306,7 @@ visible_commands = {
     "roll-chromium-deps": RollChromiumDEPS,
     "rollout": Rollout,
     "whois": Whois,
+    "yt?": YouThere,
 }
 
 # Add revert as an "easter egg" command. Why?

diff --git a/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py b/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py
index b65b0c331f307606c544a63fdf3b5f75a7b92668..b098cb3c3df0fb6611083cdce86610891c90aeee 100644 (file)
--- a/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py
+++ b/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py
@@ -37,6 +37,7 @@ from webkitpy.tool.bot.irc_command import Help
 from webkitpy.tool.bot.irc_command import Hi
 from webkitpy.tool.bot.irc_command import PingPong
 from webkitpy.tool.bot.irc_command import Restart
+from webkitpy.tool.bot.irc_command import YouThere
 from webkitpy.tool.bot.ircbot import IRCBot
 from webkitpy.tool.commands.queues import AbstractQueue
 from webkitpy.tool.commands.stepsequence import StepSequenceErrorHandler
@@ -52,6 +53,7 @@ class NewCommitBot(AbstractQueue, StepSequenceErrorHandler):
         "hi": Hi,
         "ping": PingPong,
         "restart": Restart,
+        "yt?": YouThere,
     }
 
     _maximum_number_of_revisions_to_avoid_spamming_irc = 10