Addressing more post-review comments in r177035
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Dec 2014 16:33:31 +0000 (16:33 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Dec 2014 16:33:31 +0000 (16:33 +0000)
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilitySlider.cpp
Source/WebCore/html/HTMLInputElement.cpp

index 655a7fceb972bd10102c260d2b595a1af7013fda..ed972a3dd997e28bc538b8d4a860a1ffa506dd35 100644 (file)
@@ -1,3 +1,12 @@
+2014-12-16  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Addressing more post-review comments in r177035
+
+        * accessibility/AccessibilitySlider.cpp:
+        (WebCore::AccessibilitySliderThumb::elementRect):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setupDateTimeChooserParameters):
+
 2014-12-17  Zan Dobersek  <zdobersek@igalia.com>
 
         [TexMap] Sprinkle range-based for-loops where still possible
index 15616509f19a91f54f88431bfdbc613186a006c3..23678c5c7d4071c29bf68338ee3e8d03dc20c3fb 100644 (file)
@@ -159,7 +159,7 @@ LayoutRect AccessibilitySliderThumb::elementRect() const
     RenderObject* sliderRenderer = m_parent->renderer();
     if (!sliderRenderer || !sliderRenderer->isSlider())
         return LayoutRect();
-    if (RenderElement* thumbRenderer = downcast<HTMLInputElement>(sliderRenderer->node())->sliderThumbElement()->renderer())
+    if (auto* thumbRenderer = downcast<RenderSlider>(*sliderRenderer).element().renderer())
         return thumbRenderer->absoluteBoundingBoxRect();
     return LayoutRect();
 }
index c580165f683c22a40d73150b44005f0810440c46..a219b9f7f13573999e879e62f782193bc8f4bfe0 100644 (file)
@@ -1877,7 +1877,7 @@ bool HTMLInputElement::setupDateTimeChooserParameters(DateTimeChooserParameters&
         parameters.stepBase = 0;
     }
 
-    if (RenderObject* renderer = this->renderer())
+    if (RenderElement* renderer = this->renderer())
         parameters.anchorRectInRootView = document().view()->contentsToRootView(renderer->absoluteBoundingBoxRect());
     else
         parameters.anchorRectInRootView = IntRect();