Bugzilla should show bubbles from webkit-queues.appspot.com
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Apr 2013 00:00:32 +0000 (00:00 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Apr 2013 00:00:32 +0000 (00:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=114391

Reviewed by Benjamin Poulain.

Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.

* code-review.js:
* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:
* template/en/custom/attachment/reviewform.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/bugs.webkit.org/ChangeLog
Websites/bugs.webkit.org/code-review.js
Websites/bugs.webkit.org/template/en/custom/attachment/edit.html.tmpl
Websites/bugs.webkit.org/template/en/custom/attachment/list.html.tmpl
Websites/bugs.webkit.org/template/en/custom/attachment/reviewform.html.tmpl

index fed773dfd2de3f033cc1938c5368469e0a002d58..2f2d94418a1c2beb17e29f5d32b85f05a113bec7 100644 (file)
@@ -1,3 +1,17 @@
+2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Bugzilla should show bubbles from webkit-queues.appspot.com
+        https://bugs.webkit.org/show_bug.cgi?id=114391
+
+        Reviewed by Benjamin Poulain.
+
+        Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.
+
+        * code-review.js:
+        * template/en/custom/attachment/edit.html.tmpl:
+        * template/en/custom/attachment/list.html.tmpl:
+        * template/en/custom/attachment/reviewform.html.tmpl:
+
 2013-03-21  Ryosuke Niwa  <rniwa@webkit.org>
 
         EWS bubbles need more space
index 16b5d65573194d5448b016b06ea9a920ed015b60..854a2598429418fee1842439b59a965a5b1d7cee 100644 (file)
@@ -547,6 +547,7 @@ var CODE_REVIEW_UNITTEST;
 
   function handleStatusBubbleLoad(e) {
     e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-commit-queue.appspot.com');
+    e.target.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.appspot.com');
   }
 
   function fetchHistory() {
@@ -581,6 +582,14 @@ var CODE_REVIEW_UNITTEST;
       statusBubble.onload = handleStatusBubbleLoad;
       $('#statusBubbleContainer').append(statusBubble);
 
+      statusBubble = document.createElement('iframe');
+      statusBubble.className = 'statusBubble';
+      statusBubble.src  = 'https://webkit-queues.appspot.com/status-bubble/' + attachment_id;
+      statusBubble.scrolling = 'no';
+      // Can't append the HTML because we need to set the onload handler before appending the iframe to the DOM.
+      statusBubble.onload = handleStatusBubbleLoad;
+      $('#statusBubbleContainer').append(statusBubble);
+
       $('#toolbar .bugLink').html('<a href="/show_bug.cgi?id=' + bug_id + '" target="_blank">Bug ' + bug_id + '</a>');
     });
   }
index 784f236d0ef30f913a2aab236351ab7fad7b6cb6..4a347410ed47a61f322b20fb99bd6fa95d76e993 100644 (file)
           <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
                   style="width: 480px; height: 40px; border: none;" scrolling="no">
           </iframe>
+          <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
+                  style="width: 480px; height: 40px; border: none;" scrolling="no">
+          </iframe>
         </div>
         <br>
         [% END %]
index 669a19efa3a055421a32644dce4c9a2b656b5f11..4845d09e31d9c78b522757b41101e1c8f61a5366 100644 (file)
             [% END %]
           <div class="statusBubble">
             <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
-                    style="width: 600px; height: 20px; border: none;" scrolling="no">
+                    style="width: 450px; height: 20px; border: none;" scrolling="no">
+            </iframe>
+            <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
+                    style="width: 450px; height: 20px; border: none;" scrolling="no">
             </iframe>
           </div>
           [% END %]
index 4ccdd7343f68316093b64aa62720c6b835cf3c4f..9fb6a555318a38ea510a70ccfa4db77d82bee9c6 100644 (file)
         <iframe src="https://webkit-commit-queue.appspot.com/status-bubble/[% attachment.id %]"
                 style="width: 450px; height: 20px; border: none;" scrolling="no">
         </iframe>
+        <iframe src="https://webkit-queues.appspot.com/status-bubble/[% attachment.id %]"
+                style="width: 450px; height: 20px; border: none;" scrolling="no">
+        </iframe>
       </div>
     </td>
     </tr>