Reviewed by Darin.
authorthatcher <thatcher@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Aug 2006 00:41:15 +0000 (00:41 +0000)
committerthatcher <thatcher@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Aug 2006 00:41:15 +0000 (00:41 +0000)
        * WebView/WebFrame.m:
        (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
        * WebView/WebView.m:
        (-[WebViewPrivate dealloc]): release the background color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView/WebFrame.m
WebKit/WebView/WebView.m

index b52cebf1c6b902ff87e1070970f4e9800137110a..95abf80562b89a8c699b71350e2e610659e47fe9 100644 (file)
@@ -1,3 +1,12 @@
+2006-08-24  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Darin.
+
+        * WebView/WebFrame.m:
+        (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
+        * WebView/WebView.m:
+        (-[WebViewPrivate dealloc]): release the background color
+
 2006-08-24  Timothy Hatcher  <timothy@apple.com>
 
         Reviewed by Hyatt.
index 76bdb0c6486d30f65a315af20d1401d4ecc1a6b8..f5d1bc1936e9f2f55f03477c9dffc2e7ebf554e9 100644 (file)
@@ -2242,8 +2242,8 @@ static inline WebFrame *Frame(WebCoreFrameBridge *bridge)
     NSColor *backgroundColor = [[self webView] backgroundColor];
 
     for (WebFrame *frame = self; frame; frame = [frame _traverseNextFrameStayWithin:self]) {
-        // Never call setDrawsBackground:YES on the scroll view or the background color will
-        // flash between pages loads, very noticeable during the PLT.
+        // Never call setDrawsBackground:YES here on the scroll view or the background color will
+        // flash between pages loads. setDrawsBackground:YES will be called in WebFrame's _frameLoadCompleted.
         if (!drawsBackground)
             [[[frame frameView] _scrollView] setDrawsBackground:NO];
         [[[frame frameView] _scrollView] setBackgroundColor:backgroundColor];
index ab45fdd12b4dae40b4c1d64f43f761b31b27c903..90fe2ec8f405567e8035226bd5c64d5d78ff275a 100644 (file)
@@ -395,6 +395,7 @@ NSString *_WebMainFrameDocumentKey =    @"mainFrameDocument";
     [backForwardList release];
     [applicationNameForUserAgent release];
     [userAgent release];
+    [backgroundColor release];
     
     [preferences release];
     [settings release];