Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9880
          Memory leaks running DOM-Hanoi

        No change in behavior, thus no test included.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries -
        the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 91bccc5ff58203e3c7c4aa476901e453e8142949..778e8e6a36d92f4d43f906ebf83cb52c0c51966c 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2006-07-13  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Darin.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9880
+          Memory leaks running DOM-Hanoi
+
+        No change in behavior, thus no test included.
+
+        * bridge/mac/FrameMac.mm:
+        (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries - 
+        the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.
+
 2006-07-12  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 
         Reviewed by Adele.

diff --git a/WebCore/bridge/mac/FrameMac.mm b/WebCore/bridge/mac/FrameMac.mm
index c890e4de52c42d5fdcc3c245dc5d22d6698324b8..5d99637b08bb1e057a3b52d16c3682c40bd172e7 100644 (file)
--- a/WebCore/bridge/mac/FrameMac.mm
+++ b/WebCore/bridge/mac/FrameMac.mm
@@ -610,9 +610,15 @@ void FrameMac::setStatusBarText(const String& status)
     String text = status;
     text.replace('\\', backslashAsCurrencySymbol());
     
+    // We want the temporaries allocated here to be released even before returning to the 
+    // event loop; see <http://bugzilla.opendarwin.org/show_bug.cgi?id=9880>.
+    NSAutoreleasePool* localPool = [[NSAutoreleasePool alloc] init];
+
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
     [_bridge setStatusText:text];
     END_BLOCK_OBJC_EXCEPTIONS;
+
+    [localPool release];
 }
 
 void FrameMac::scheduleClose()