[EFL] accessibility/loading-iframe-sends-notification.html is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Sep 2013 11:02:23 +0000 (11:02 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Sep 2013 11:02:23 +0000 (11:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112003

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Enabled AXLayoutComplete on EFL platform.

* dom/Document.cpp:
(WebCore::Document::implicitClose):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

Tools:

Enabled addNotificationListener and removeNotificationListener for EFL port.

* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::removeNotificationListener):

LayoutTests:

* platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
* platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl-wk1/TestExpectations
LayoutTests/platform/efl-wk2/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/dom/Document.cpp
Source/WebCore/page/FrameView.cpp
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp

index 605259c72da7dd2b08a13622c8e1eb7b425c74bd..3ee172591f81acfd205f6b881605a49fd8804199 100644 (file)
@@ -1,3 +1,13 @@
+2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        * platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
+        * platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.
+
 2013-09-24  Ryosuke Niwa  <rniwa@webkit.org>
 
         Crash in Document::setFocusedElement
index 9571d04e507a0d3636ca14b4ed84e11bcfc7fee0..9bd8ac492ee2e36008e3dcc20deabba5db46a2a3 100644 (file)
@@ -157,7 +157,6 @@ webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
 webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]
-webkit.org/b/112003 accessibility/loading-iframe-sends-notification.html [ Failure ]
 webkit.org/b/112023 accessibility/loading-iframe-updates-axtree.html [ Failure ]
 webkit.org/b/112005 accessibility/onclick-handlers.html [ Failure ]
 webkit.org/b/112006 accessibility/secure-textfield-title-ui.html [ Failure ]
index 9d3266993bd016ab89176503296d29f0397f77d4..57c5dea9bda7a45ad1c157b86684c7c9e1962c58 100644 (file)
@@ -168,7 +168,6 @@ webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
 webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
 webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]
-webkit.org/b/112003 accessibility/loading-iframe-sends-notification.html [ Failure ]
 webkit.org/b/112005 accessibility/onclick-handlers.html [ Failure ]
 webkit.org/b/112006 accessibility/secure-textfield-title-ui.html [ Failure ]
 webkit.org/b/112008 accessibility/spinbutton-value.html [ Failure ]
index f9e786d4013a24f168f0ae2284043185ba364130..763312c7eeb05e26060eaeed78c58b6424fa72a0 100644 (file)
@@ -1,3 +1,17 @@
+2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        Enabled AXLayoutComplete on EFL platform.
+
+        * dom/Document.cpp:
+        (WebCore::Document::implicitClose):
+        * page/FrameView.cpp:
+        (WebCore::FrameView::layout):
+
 2013-09-24  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r156379.
index 149d89ac64777d6e125075be55b322a52cbe016b..80d503ee2a48641526507b7c678dd1252bf606fb 100644 (file)
@@ -2484,7 +2484,7 @@ void Document::implicitClose()
 
     m_processingLoadEvent = false;
 
-#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(EFL)
     if (f && hasLivingRenderTree() && AXObjectCache::accessibilityEnabled()) {
         // The AX cache may have been cleared at this point, but we need to make sure it contains an
         // AX object to send the notification to. getOrCreate will make sure that an valid AX object
index 02300e208cea710aa41de286d1e64c570ed03f8b..d131f40e388606bc9bc93fdd0ae56c7973db4083 100644 (file)
@@ -1325,7 +1325,7 @@ void FrameView::layout(bool allowSubtree)
     
     m_layoutCount++;
 
-#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(EFL)
     if (AXObjectCache* cache = root->document().existingAXObjectCache())
         cache->postNotification(root, AXObjectCache::AXLayoutComplete);
 #endif
index c3dd9c29ed7ee934f5917481e476a2620625f5ac..5d15f147afa4d4d0938c5bf3abc9a0dee1c29730 100644 (file)
@@ -1,3 +1,16 @@
+2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
+
+        [EFL] accessibility/loading-iframe-sends-notification.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=112003
+
+        Reviewed by Mario Sanchez Prada.
+
+        Enabled addNotificationListener and removeNotificationListener for EFL port.
+
+        * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
+        (WTR::AccessibilityController::removeNotificationListener):
+
 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
 
         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
index 40259b6ccf30cf1801bdf529b3765b7af2256782..fb43cfb7cbc325dfd6de55911bb4331b20abb15f 100644 (file)
@@ -97,7 +97,7 @@ PassRefPtr<AccessibilityUIElement> AccessibilityController::elementAtPoint(int x
 
 // Unsupported methods on various platforms.
 // As they're implemented on other platforms this list should be modified.
-#if !PLATFORM(GTK) && !PLATFORM(MAC)
+#if !PLATFORM(GTK) && !PLATFORM(MAC) && !PLATFORM(EFL)
 bool AccessibilityController::addNotificationListener(JSValueRef) { return false; }
 bool AccessibilityController::removeNotificationListener() { return false; }
 #endif
index ef7d055ca41dcb2b04bd2c9a544444c996fc03c5..bac1edfa211e08d41e482b08a3d9f57843f963c0 100644 (file)
@@ -128,7 +128,6 @@ PassRefPtr<AccessibilityUIElement> AccessibilityController::focusedElement()
     return AccessibilityUIElement::create(static_cast<AtkObject*>(root));
 }
 
-#if PLATFORM(GTK)
 bool AccessibilityController::addNotificationListener(JSValueRef functionCallback)
 {
     if (!functionCallback)
@@ -150,6 +149,5 @@ bool AccessibilityController::removeNotificationListener()
     m_globalNotificationHandler = 0;
     return false;
 }
-#endif
 
 } // namespace WTR