Reviewed by Oliver.
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 30 Dec 2007 00:33:20 +0000 (00:33 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 30 Dec 2007 00:33:20 +0000 (00:33 +0000)
        - fix http://bugs.webkit.org/show_bug.cgi?id=16663
          leak bot shows createCStringFromNPVariant result leaking

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginInvoke): Added a missing free.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp

index 6517c21a70566a71e78d45765cc4474c669852dd..384550177ae25ecfb7ad28771f3e3a1c2e1c87ed 100644 (file)
@@ -1,3 +1,13 @@
+2007-12-29  Darin Adler  <darin@apple.com>
+
+        Reviewed by Oliver.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=16663
+          leak bot shows createCStringFromNPVariant result leaking
+
+        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
+        (pluginInvoke): Added a missing free.
+
 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 
         Reviewed by Alp Toker.
index eed2261e8dcdbd0e733c50b0f332b83d1b075e6c..36799ffe013a4c22af660da76cf5f50de865fc70 100644 (file)
@@ -336,8 +336,9 @@ static bool pluginInvoke(NPObject *header, NPIdentifier name, const NPVariant *a
 
         for (uint32_t i = 0; i < argCount; i++) {
             assert(NPVARIANT_IS_STRING(args[i]));
-            char *propertyString = createCStringFromNPVariant(&args[i]);
+            NPUTF8* propertyString = createCStringFromNPVariant(&args[i]);
             NPIdentifier propertyIdentifier = browser->getstringidentifier(propertyString);
+            free(propertyString);
             
             NPVariant variant;
             bool retval = browser->getproperty(obj->npp, object, propertyIdentifier, &variant);