REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Apr 2014 00:37:57 +0000 (00:37 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Apr 2014 00:37:57 +0000 (00:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131409

Reviewed by Anders Carlsson.

Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/WebPage.cpp

index d136a9745300dab2be997ebc8cd7e6c793fb5483..f5923d4a9d1f6ab30203349c0b713c86013901f5 100644 (file)
@@ -1,3 +1,16 @@
+2014-04-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
+        https://bugs.webkit.org/show_bug.cgi?id=131409
+
+        Reviewed by Anders Carlsson.
+
+        Create an empty API::InjectedBundle::FormClient to avoid crashing inside
+        m_mainFrame->coreFrame()->loader().detachFromParent().
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::close):
+
 2014-04-08  Tim Horton  <timothy_horton@apple.com>
 
         Unify and factor out page overlay implementations
index b6ab77d54f20c495b3febedd2fb4595f33704290..e128a1fe44f6d55e074108b6f5c5c920deda0e4d 100644 (file)
@@ -886,7 +886,7 @@ void WebPage::close()
     m_contextMenuClient.initialize(0);
 #endif
     m_editorClient.initialize(0);
-    m_formClient = std::unique_ptr<API::InjectedBundle::FormClient>();
+    m_formClient = std::make_ptr<API::InjectedBundle::FormClient>();
     m_loaderClient.initialize(0);
     m_policyClient.initialize(0);
     m_resourceLoadClient.initialize(0);