Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loadi...
authorcblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jan 2005 00:49:51 +0000 (00:49 +0000)
committercblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jan 2005 00:49:51 +0000 (00:49 +0000)
        Reviewed by john.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/Plugins.subproj/WebBaseNetscapePluginView.m

index b2ee409caf34d7853cd89112ff22a7b85065c4e2..ee73445ba493a8e3e8772bcf8f6e1a4ca180393a 100644 (file)
@@ -1,3 +1,12 @@
+2005-01-11  Chris Blumenberg  <cblu@apple.com>
+
+       Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loading movie
+
+        Reviewed by john.
+
+        * Plugins.subproj/WebBaseNetscapePluginView.m:
+        (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView
+
 2005-01-11  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Darin.
index ed856fb5a13287c73e5805b00dbde3d4b36494a3..13e5cc6878381184bb7c8765c4a955501804513b 100644 (file)
@@ -890,8 +890,13 @@ static OSStatus TSMEventHandler(EventHandlerCallRef inHandlerRef, EventRef inEve
         return YES;
     }
 
+    if (![self canStart]) {
+        return NO;
+    }
+    
     ASSERT([self webView]);
-    if (![[[self webView] preferences] arePlugInsEnabled] || ![self canStart]) {
+    
+    if (![[[self webView] preferences] arePlugInsEnabled]) {
         return NO;
     }