https://bugs.webkit.org/show_bug.cgi?id=132382
Reviewed by Benjamin Poulain.
PerformanceTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
* Layout/auto-grid-lots-of-data.html:
* Layout/fixed-grid-lots-of-data.html:
Source/WebCore:
Remove cssGridLayoutEnabled setting. Update methods using it accordingly.
* WebCore.order:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::cssGridLayoutEnabled): Deleted.
* css/CSSParser.h:
* css/CSSParserMode.h:
* dom/Document.cpp:
(WebCore::Document::cssGridLayoutEnabled): Deleted.
* dom/Document.h:
* page/Settings.in:
Source/WebKit/efl:
Remove cssGridLayoutEnabled setting usage.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled): Deleted.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/mac:
Remove cssGridLayoutEnabled setting usage.
* WebKit.order:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]): Deleted.
(-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Remove cssGridLayoutEnabled setting usage.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSGridLayoutEnabled): Deleted.
(WKPreferencesGetCSSGridLayoutEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed):
* UIProcess/gtk/ExperimentalFeatures.cpp:
* UIProcess/gtk/ExperimentalFeatures.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* mac/WebKit2.order:
Tools:
Remove cssGridLayoutEnabled setting usage.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
LayoutTests:
Remove set of WebKitCSSGridLayoutEnabled preference.
Remove fast/css-grid-layout/grid-disabled.html patch as the setting is not available anymore.
* fast/css-grid-layout/anonymous-grid-items-expected.html:
* fast/css-grid-layout/anonymous-grid-items.html:
* fast/css-grid-layout/auto-content-resolution-columns.html:
* fast/css-grid-layout/auto-content-resolution-rows.html:
* fast/css-grid-layout/breadth-size-resolution-grid.html:
* fast/css-grid-layout/calc-resolution-grid-item.html:
* fast/css-grid-layout/containing-block-grids.html:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-resolution-columns.html:
* fast/css-grid-layout/flex-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
* fast/css-grid-layout/flex-content-sized-columns-resize.html:
* fast/css-grid-layout/floating-empty-grids.html:
* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
* fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-update.html:
* fast/css-grid-layout/grid-auto-flow-get-set.html:
* fast/css-grid-layout/grid-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-flow-update.html:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
* fast/css-grid-layout/grid-disabled-expected.txt: Removed.
* fast/css-grid-layout/grid-disabled.html: Removed.
* fast/css-grid-layout/grid-dynamic-updates-relayout.html:
* fast/css-grid-layout/grid-element-border-grid-item.html:
* fast/css-grid-layout/grid-element-border-padding-grid-item.html:
* fast/css-grid-layout/grid-element-change-columns-repaint.html:
* fast/css-grid-layout/grid-element-change-rows-repaint.html:
* fast/css-grid-layout/grid-element-empty-row-column.html:
* fast/css-grid-layout/grid-element-min-max-height.html:
* fast/css-grid-layout/grid-element-min-max-width.html:
* fast/css-grid-layout/grid-element-padding-grid-item.html:
* fast/css-grid-layout/grid-element-padding-margin.html:
* fast/css-grid-layout/grid-element-repeat-get-set.html:
* fast/css-grid-layout/grid-element-shrink-to-fit.html:
* fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
* fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
* fast/css-grid-layout/grid-item-area-get-set.html:
* fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
* fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
* fast/css-grid-layout/grid-item-change-column-repaint.html:
* fast/css-grid-layout/grid-item-change-row-repaint.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
* fast/css-grid-layout/grid-item-margin-resolution.html:
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
* fast/css-grid-layout/grid-item-negative-indexes.html:
* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
* fast/css-grid-layout/grid-item-negative-position-resolution.html:
* fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
* fast/css-grid-layout/grid-item-order-paint-order.html:
* fast/css-grid-layout/grid-item-position-changed-dynamic.html:
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
* fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
* fast/css-grid-layout/grid-item-spanning-resolution.html:
* fast/css-grid-layout/grid-item-start-before-get-set.html:
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
* fast/css-grid-layout/grid-preferred-logical-widths.html:
* fast/css-grid-layout/grid-strict-ordering-crash.html:
* fast/css-grid-layout/grid-template-areas-get-set.html:
* fast/css-grid-layout/grid-template-shorthand-get-set.html:
* fast/css-grid-layout/implicit-columns-auto-resolution.html:
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/implicit-rows-auto-resolution.html:
* fast/css-grid-layout/minmax-fixed-logical-height-only.html:
* fast/css-grid-layout/minmax-fixed-logical-width-only.html:
* fast/css-grid-layout/minmax-max-content-resolution-columns.html:
* fast/css-grid-layout/minmax-max-content-resolution-rows.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
* fast/css-grid-layout/minmax-spanning-resolution-columns.html:
* fast/css-grid-layout/minmax-spanning-resolution-rows.html:
* fast/css-grid-layout/named-grid-line-get-set.html:
* fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
* fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set.html:
* fast/css-grid-layout/non-grid-element-repeat-get-set.html:
* fast/css-grid-layout/non-named-grid-line-get-set.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
* fast/css-grid-layout/percent-resolution-grid-item.html:
* fast/css-grid-layout/place-cell-by-index.html:
* fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
* ietestcenter/css3/grid/grid-column-002.htm:
* ietestcenter/css3/grid/testRunnerEnableGrid.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove set of WebKitCSSGridLayoutEnabled preference.
+ Remove fast/css-grid-layout/grid-disabled.html patch as the setting is not available anymore.
+
+ * fast/css-grid-layout/anonymous-grid-items-expected.html:
+ * fast/css-grid-layout/anonymous-grid-items.html:
+ * fast/css-grid-layout/auto-content-resolution-columns.html:
+ * fast/css-grid-layout/auto-content-resolution-rows.html:
+ * fast/css-grid-layout/breadth-size-resolution-grid.html:
+ * fast/css-grid-layout/calc-resolution-grid-item.html:
+ * fast/css-grid-layout/containing-block-grids.html:
+ * fast/css-grid-layout/display-grid-set-get.html:
+ * fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
+ * fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
+ * fast/css-grid-layout/flex-content-resolution-columns.html:
+ * fast/css-grid-layout/flex-content-resolution-rows.html:
+ * fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
+ * fast/css-grid-layout/flex-content-sized-columns-resize.html:
+ * fast/css-grid-layout/floating-empty-grids.html:
+ * fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
+ * fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
+ * fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
+ * fast/css-grid-layout/grid-auto-columns-rows-update.html:
+ * fast/css-grid-layout/grid-auto-flow-get-set.html:
+ * fast/css-grid-layout/grid-auto-flow-resolution.html:
+ * fast/css-grid-layout/grid-auto-flow-update.html:
+ * fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
+ * fast/css-grid-layout/grid-columns-rows-get-set.html:
+ * fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
+ * fast/css-grid-layout/grid-disabled-expected.txt: Removed.
+ * fast/css-grid-layout/grid-disabled.html: Removed.
+ * fast/css-grid-layout/grid-dynamic-updates-relayout.html:
+ * fast/css-grid-layout/grid-element-border-grid-item.html:
+ * fast/css-grid-layout/grid-element-border-padding-grid-item.html:
+ * fast/css-grid-layout/grid-element-change-columns-repaint.html:
+ * fast/css-grid-layout/grid-element-change-rows-repaint.html:
+ * fast/css-grid-layout/grid-element-empty-row-column.html:
+ * fast/css-grid-layout/grid-element-min-max-height.html:
+ * fast/css-grid-layout/grid-element-min-max-width.html:
+ * fast/css-grid-layout/grid-element-padding-grid-item.html:
+ * fast/css-grid-layout/grid-element-padding-margin.html:
+ * fast/css-grid-layout/grid-element-repeat-get-set.html:
+ * fast/css-grid-layout/grid-element-shrink-to-fit.html:
+ * fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
+ * fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
+ * fast/css-grid-layout/grid-item-area-get-set.html:
+ * fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
+ * fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
+ * fast/css-grid-layout/grid-item-change-column-repaint.html:
+ * fast/css-grid-layout/grid-item-change-row-repaint.html:
+ * fast/css-grid-layout/grid-item-column-row-get-set.html:
+ * fast/css-grid-layout/grid-item-end-after-get-set.html:
+ * fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
+ * fast/css-grid-layout/grid-item-margin-resolution.html:
+ * fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
+ * fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
+ * fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
+ * fast/css-grid-layout/grid-item-negative-indexes.html:
+ * fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
+ * fast/css-grid-layout/grid-item-negative-position-resolution.html:
+ * fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
+ * fast/css-grid-layout/grid-item-order-paint-order.html:
+ * fast/css-grid-layout/grid-item-position-changed-dynamic.html:
+ * fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
+ * fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
+ * fast/css-grid-layout/grid-item-spanning-resolution.html:
+ * fast/css-grid-layout/grid-item-start-before-get-set.html:
+ * fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
+ * fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
+ * fast/css-grid-layout/grid-preferred-logical-widths.html:
+ * fast/css-grid-layout/grid-strict-ordering-crash.html:
+ * fast/css-grid-layout/grid-template-areas-get-set.html:
+ * fast/css-grid-layout/grid-template-shorthand-get-set.html:
+ * fast/css-grid-layout/implicit-columns-auto-resolution.html:
+ * fast/css-grid-layout/implicit-position-dynamic-change.html:
+ * fast/css-grid-layout/implicit-rows-auto-resolution.html:
+ * fast/css-grid-layout/minmax-fixed-logical-height-only.html:
+ * fast/css-grid-layout/minmax-fixed-logical-width-only.html:
+ * fast/css-grid-layout/minmax-max-content-resolution-columns.html:
+ * fast/css-grid-layout/minmax-max-content-resolution-rows.html:
+ * fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
+ * fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
+ * fast/css-grid-layout/minmax-spanning-resolution-columns.html:
+ * fast/css-grid-layout/minmax-spanning-resolution-rows.html:
+ * fast/css-grid-layout/named-grid-line-get-set.html:
+ * fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
+ * fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
+ * fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
+ * fast/css-grid-layout/non-grid-columns-rows-get-set.html:
+ * fast/css-grid-layout/non-grid-element-repeat-get-set.html:
+ * fast/css-grid-layout/non-named-grid-line-get-set.html:
+ * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
+ * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
+ * fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
+ * fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
+ * fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
+ * fast/css-grid-layout/percent-resolution-grid-item.html:
+ * fast/css-grid-layout/place-cell-by-index.html:
+ * fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
+ * ietestcenter/css3/grid/grid-column-002.htm:
+ * ietestcenter/css3/grid/testRunnerEnableGrid.js: Removed.
+
2014-05-07 Lorenzo Tilve <ltilve@igalia.com>
[GTK] Unreviewed GTK gardening
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<body>
<div>Checks that anonymous grid items are supported. This should not crash.</div>
<div style="display: -webkit-grid;">
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<body>
<div>Checks that anonymous grid items are supported. This should not crash.</div>
<div style="display: -webkit-grid;">
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
- <script>
- if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
- </script>
<link href="resources/grid.css" rel="stylesheet">
<style>
div { width: 100px; height: 100px; }
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<script src="../../resources/js-test-pre.js"></script>
</head>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMaxMaxContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMaxMaxContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinFlexContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinFlexContent {
<!DOCTYPE html>
<html>
<head>
- <script>
- if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
- </script>
<link href="resources/grid.css" rel="stylesheet">
<style type="text/css">
#grid-1 {
<!DOCTYPE html>
<html>
<head>
-<script>
- if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style type="text/css">
#grid-1 {
<!DOCTYPE html>
<html>
<head>
- <script>
- if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
- </script>
<style>
span { width: 100px; height: 100px; }
.grid { display: -webkit-grid; background-color: green; }
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoFixedFixed {
<!DOCTYPE HTML>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE HTML>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoFlowInherit {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.smallGrid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<script src="../../resources/check-layout.js"></script>
<style>
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<script src="../../resources/check-layout.js"></script>
<style type="text/css">
+++ /dev/null
-Verifies that display: -webkit-grid does nothing if runtime feature is disabled.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS document.getElementById('grid').style.display is ''
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+++ /dev/null
-<!DOCTYPE html>
-<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 0);
-</script>
-<body>
-<div id="grid" style="display: -webkit-grid"></div>
-
-<script src="../../resources/js-test-pre.js"></script>
-<script>
-description("Verifies that display: -webkit-grid does nothing if runtime feature is disabled.");
-
-shouldBe("document.getElementById('grid').style.display", "''");
-</script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<script src="../../resources/check-layout.js"></script>
<script>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<script src="../../resources/check-layout.js"></script>
<link href="resources/grid.css" rel="stylesheet">
<style>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<script src="../../resources/check-layout.js"></script>
<link href="resources/grid.css" rel="stylesheet">
<style>
<html>
<script src="../repaint/resources/text-based-repaint.js"></script>
<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-
function repaintTest()
{
var gridElement = document.getElementsByClassName("grid")[0];
<html>
<script src="../repaint/resources/text-based-repaint.js"></script>
<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-
function repaintTest()
{
var gridElement = document.getElementsByClassName("grid")[0];
<!DOCTYPE html>
<html>
-<script>
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href=resources/grid.css rel=stylesheet>
<style>
.gridNoRow {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel=stylesheet>
<style>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel=stylesheet>
<style>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<script src="../../resources/check-layout.js"></script>
<link href="resources/grid.css" rel="stylesheet">
<style>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridFixedContent {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet"/>
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<html>
<script src="../repaint/resources/text-based-repaint.js"></script>
<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-
function repaintTest()
{
var gridItem = document.getElementsByClassName("sizedToGridArea")[0];
<html>
<script src="../repaint/resources/text-based-repaint.js"></script>
<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-
function repaintTest()
{
var gridItem = document.getElementsByClassName("sizedToGridArea")[0];
<html>
<head>
<script src="resources/grid-item-column-row-parsing-utils.js"></script>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<style>
.grid {
-webkit-grid-template-areas: "firstArea secondArea"
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<script src="../../resources/check-layout.js"></script>
<link href="resources/grid.css" rel="stylesheet">
<style>
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMaxAutoWithColumnMinMaxAuto {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet"/>
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridWithoutRepeat {
<!DOCTYPE html>
-<script>
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.negativeStartBeforePositionIndexes {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.columnGrid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style type="text/css">
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMaxMinMax {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
<head>
-<script>
- if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel=stylesheet>
<link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel=stylesheet>
<style>
<!DOCTYPE html>
<script>
if (window.testRunner) {
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
testRunner.dumpAsText();
}
</script>
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
#gridWithSingleStringTemplate {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
#gridTemplateWithNone {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridFixedContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMaxContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMaxContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMinContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridMinMinContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoAutoContent {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridAutoAutoContent {
<!DOCTYPE HTML>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<html>
<head>
<link href="resources/grid.css" rel="stylesheet">
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<style type="text/css">
.gridAreas {
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style type="text/css">
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridWithFixed {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridWithNone {
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.singleSingleTrackRepeat {
<!DOCTYPE HTML>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.gridItem {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.container {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<!DOCTYPE html>
<html>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<link href="resources/grid.css" rel="stylesheet">
<style>
.grid {
<html>
<script>
if (window.testRunner) {
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
testRunner.dumpAsText();
}
</script>
<link rel="help" href="http://dev.w3.org/csswg/css3-grid-align/#grid-declaration" />
<meta name="flags" content="ahem invalid" />
<meta name="assert" content="The 'grid-column' with a value of '0' is invalid and inserts the grid-item in the first column." />
- <script src="testRunnerEnableGrid.js"></script>
<style type="text/css">
#test
{
+++ /dev/null
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove set of WebKitCSSGridLayoutEnabled preference.
+
+ * Layout/auto-grid-lots-of-data.html:
+ * Layout/fixed-grid-lots-of-data.html:
+
2014-05-06 Radu Stavila <stavila@adobe.com>
[CSSRegions] Enabled regions performance tests by default
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<style>
html, body {
margin: 0;
<!DOCTYPE html>
<html>
<head>
-<script>
-if (window.testRunner)
- testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
-</script>
<style>
html, body {
margin: 0;
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove cssGridLayoutEnabled setting. Update methods using it accordingly.
+
+ * WebCore.order:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParserContext::CSSParserContext):
+ (WebCore::operator==):
+ (WebCore::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseGridTemplateShorthand):
+ (WebCore::CSSParser::parseGridAreaShorthand):
+ (WebCore::CSSParser::cssGridLayoutEnabled): Deleted.
+ * css/CSSParser.h:
+ * css/CSSParserMode.h:
+ * dom/Document.cpp:
+ (WebCore::Document::cssGridLayoutEnabled): Deleted.
+ * dom/Document.h:
+ * page/Settings.in:
+
2014-05-07 Praveen R Jadhav <praveen.j@samsung.com>
Fix build errors for BlobDataItem after r168391.
__ZN7WebCore16CSSParserContextC2EPNS_8DocumentERKNS_4KURLERKN3WTF6StringE
__ZNK7WebCore8Document24cssStickyPositionEnabledEv
__ZNK7WebCore8Document21cssCompositingEnabledEv
-__ZNK7WebCore8Document20cssGridLayoutEnabledEv
__ZN7WebCore18StyleSheetContents14registerClientEPNS_13CSSStyleSheetE
__ZN3WTF6VectorIPN7WebCore13CSSStyleSheetELm0ENS_15CrashOnOverflowEE14expandCapacityEmPKS3_
__ZN3WTF6VectorIPN7WebCore13CSSStyleSheetELm0ENS_15CrashOnOverflowEE15reserveCapacityEm
, isHTMLDocument(false)
, isCSSRegionsEnabled(false)
, isCSSCompositingEnabled(false)
-#if ENABLE(CSS_GRID_LAYOUT)
- , isCSSGridLayoutEnabled(false)
-#endif
, needsSiteSpecificQuirks(false)
, enforcesCSSMIMETypeInNoQuirksMode(true)
, useLegacyBackgroundSizeShorthandBehavior(false)
, isHTMLDocument(document.isHTMLDocument())
, isCSSRegionsEnabled(document.cssRegionsEnabled())
, isCSSCompositingEnabled(document.cssCompositingEnabled())
-#if ENABLE(CSS_GRID_LAYOUT)
- , isCSSGridLayoutEnabled(document.cssGridLayoutEnabled())
-#endif
, needsSiteSpecificQuirks(document.settings() ? document.settings()->needsSiteSpecificQuirks() : false)
, enforcesCSSMIMETypeInNoQuirksMode(!document.settings() || document.settings()->enforceCSSMIMETypeInNoQuirksMode())
, useLegacyBackgroundSizeShorthandBehavior(document.settings() ? document.settings()->useLegacyBackgroundSizeShorthandBehavior() : false)
&& a.isHTMLDocument == b.isHTMLDocument
&& a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
&& a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
-#if ENABLE(CSS_GRID_LAYOUT)
- && a.isCSSGridLayoutEnabled == b.isCSSGridLayoutEnabled
-#endif
&& a.needsSiteSpecificQuirks == b.needsSiteSpecificQuirks
&& a.enforcesCSSMIMETypeInNoQuirksMode == b.enforcesCSSMIMETypeInNoQuirksMode
&& a.useLegacyBackgroundSizeShorthandBehavior == b.useLegacyBackgroundSizeShorthandBehavior;
if ((valueID >= CSSValueInline && valueID <= CSSValueWebkitInlineFlex) || valueID == CSSValueNone)
return true;
#if ENABLE(CSS_GRID_LAYOUT)
- if (parserContext.isCSSGridLayoutEnabled && (valueID == CSSValueWebkitGrid || valueID == CSSValueWebkitInlineGrid))
+ if (valueID == CSSValueWebkitGrid || valueID == CSSValueWebkitInlineGrid)
return true;
#endif
break;
#if ENABLE(CSS_GRID_LAYOUT)
case CSSPropertyWebkitGridAutoColumns:
case CSSPropertyWebkitGridAutoRows:
- if (!cssGridLayoutEnabled())
- return false;
parsedValue = parseGridTrackSize(*m_valueList);
break;
case CSSPropertyWebkitGridTemplateColumns:
case CSSPropertyWebkitGridTemplateRows:
- if (!cssGridLayoutEnabled())
- return false;
parsedValue = parseGridTrackList();
break;
case CSSPropertyWebkitGridColumnEnd:
case CSSPropertyWebkitGridRowStart:
case CSSPropertyWebkitGridRowEnd:
- if (!cssGridLayoutEnabled())
- return false;
-
parsedValue = parseGridPosition();
break;
case CSSPropertyWebkitGridColumn:
case CSSPropertyWebkitGridRow: {
- if (!cssGridLayoutEnabled())
- return false;
-
return parseGridItemPositionShorthand(propId, important);
}
case CSSPropertyWebkitGridTemplate:
- if (!cssGridLayoutEnabled())
- return false;
return parseGridTemplateShorthand(important);
case CSSPropertyWebkitGridArea:
- if (!cssGridLayoutEnabled())
- return false;
return parseGridAreaShorthand(important);
case CSSPropertyWebkitGridTemplateAreas:
- if (!cssGridLayoutEnabled())
- return false;
-
parsedValue = parseGridTemplateAreas();
break;
#endif /* ENABLE(CSS_GRID_LAYOUT) */
bool CSSParser::parseGridTemplateShorthand(bool important)
{
- ASSERT(cssGridLayoutEnabled());
-
ShorthandScope scope(this, CSSPropertyWebkitGridTemplate);
ASSERT(shorthandForProperty(CSSPropertyWebkitGridTemplate).length() == 3);
bool CSSParser::parseGridAreaShorthand(bool important)
{
- ASSERT(cssGridLayoutEnabled());
-
ShorthandScope scope(this, CSSPropertyWebkitGridArea);
ASSERT(shorthandForProperty(CSSPropertyWebkitGridArea).length() == 4);
return m_context.isCSSCompositingEnabled;
}
-#if ENABLE(CSS_GRID_LAYOUT)
-bool CSSParser::cssGridLayoutEnabled() const
-{
- return m_context.isCSSGridLayoutEnabled;
-}
-#endif
-
#if ENABLE(CSS_REGIONS)
// none | <ident>
bool parseAnimationShorthand(bool important);
#if ENABLE(CSS_GRID_LAYOUT)
- bool cssGridLayoutEnabled() const;
PassRefPtr<CSSValue> parseGridPosition();
bool parseGridItemPositionShorthand(CSSPropertyID, bool important);
bool parseGridTemplateRowsAndAreas(PassRefPtr<CSSValue>, bool important);
bool isHTMLDocument;
bool isCSSRegionsEnabled;
bool isCSSCompositingEnabled;
-#if ENABLE(CSS_GRID_LAYOUT)
- bool isCSSGridLayoutEnabled;
-#endif
bool needsSiteSpecificQuirks;
bool enforcesCSSMIMETypeInNoQuirksMode;
bool useLegacyBackgroundSizeShorthandBehavior;
return RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled();
}
-#if ENABLE(CSS_GRID_LAYOUT)
-bool Document::cssGridLayoutEnabled() const
-{
- return settings() && settings()->cssGridLayoutEnabled();
-}
-#endif
-
#if ENABLE(CSS_REGIONS)
PassRefPtr<DOMNamedFlowCollection> Document::webkitGetNamedFlows()
NamedFlowCollection* namedFlows();
-#if ENABLE(CSS_GRID_LAYOUT)
- bool cssGridLayoutEnabled() const;
-#endif
-
Element* elementFromPoint(int x, int y) const;
PassRefPtr<Range> caretRangeFromPoint(int x, int y);
acceleratedDrawingEnabled initial=false
acceleratedFiltersEnabled initial=false
regionBasedColumnsEnabled initial=true
-cssGridLayoutEnabled initial=true
useLegacyTextAlignPositionedElementBehavior initial=false
# FIXME: This should really be disabled by default as it makes platforms that don't support the feature download files
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove cssGridLayoutEnabled setting usage.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled): Deleted.
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
2014-05-01 Ryuan Choi <ryuan.choi@samsung.com>
[EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
return page->findString(text, options);
}
-void DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled(const Evas_Object* ewkView, bool enabled)
-{
- DRT_SUPPRT_PAGE_GET_OR_RETURN(ewkView, page);
-
- page->settings().setCSSGridLayoutEnabled(enabled);
-}
-
void DumpRenderTreeSupportEfl::setCSSRegionsEnabled(const Evas_Object* ewkView, bool enabled)
{
DRT_SUPPRT_PAGE_GET_OR_RETURN(ewkView, page);
static void executeCoreCommandByName(const Evas_Object* ewkView, const char* name, const char* value);
static bool findString(const Evas_Object* ewkView, const String& text, WebCore::FindOptions);
static bool isCommandEnabled(const Evas_Object* ewkView, const char* name);
- static void setCSSGridLayoutEnabled(const Evas_Object* ewkView, bool enabled);
static void setCSSRegionsEnabled(const Evas_Object* ewkView, bool enabled);
static void setWebAudioEnabled(Evas_Object* ewkView, bool);
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove cssGridLayoutEnabled setting usage.
+
+ * WebKit.order:
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences cssGridLayoutEnabled]): Deleted.
+ (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2014-05-06 Dean Jackson <dino@apple.com>
[Mac] Allow focus rings to redraw themselves if necessary
-[WebPreferences(WebPrivate) cssCompositingEnabled]
-[WebPreferences(WebPrivate) webAudioEnabled]
-[WebPreferences(WebPrivate) seamlessIFramesEnabled]
--[WebPreferences(WebPrivate) cssGridLayoutEnabled]
-[WebPreferences(WebPrivate) fullScreenEnabled]
-[WebPreferences(WebPrivate) asynchronousSpellCheckingEnabled]
-[WebPreferences(WebPrivate) hyperlinkAuditingEnabled]
-[WebPreferences(WebPrivate) setCanvasUsesAcceleratedDrawing:]
-[WebPreferences(WebPrivate) setAcceleratedDrawingEnabled:]
-[WebPreferences(WebPrivate) setCSSRegionsEnabled:]
--[WebPreferences(WebPrivate) setCSSGridLayoutEnabled:]
-[WebPreferences(WebPrivate) setUsePreHTML5ParserQuirks:]
-[WebPreferences(WebPrivate) setAsynchronousSpellCheckingEnabled:]
-[WebPreferences(WebPrivate) setMockScrollbarsEnabled:]
#define WebKitAcceleratedCompositingEnabledPreferenceKey @"WebKitAcceleratedCompositingEnabled"
#define WebKitCSSRegionsEnabledPreferenceKey @"WebKitCSSRegionsEnabled"
#define WebKitCSSCompositingEnabledPreferenceKey @"WebKitCSSCompositingEnabled"
-#define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
#define WebKitShowDebugBordersPreferenceKey @"WebKitShowDebugBorders"
#define WebKitShowRepaintCounterPreferenceKey @"WebKitShowRepaintCounter"
#define WebKitWebAudioEnabledPreferenceKey @"WebKitWebAudioEnabled"
[NSNumber numberWithBool:YES], WebKitAcceleratedCompositingEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCSSGridLayoutEnabledPreferenceKey,
#if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
[NSNumber numberWithBool:YES], WebKitAcceleratedDrawingEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitCanvasUsesAcceleratedDrawingPreferenceKey,
[self _setBoolValue:enabled forKey:WebKitCSSCompositingEnabledPreferenceKey];
}
-- (BOOL)cssGridLayoutEnabled
-{
- return [self _boolValueForKey:WebKitCSSGridLayoutEnabledPreferenceKey];
-}
-
-- (void)setCSSGridLayoutEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitCSSGridLayoutEnabledPreferenceKey];
-}
-
- (BOOL)showDebugBorders
{
return [self _boolValueForKey:WebKitShowDebugBordersPreferenceKey];
- (BOOL)cssCompositingEnabled;
- (void)setCSSCompositingEnabled:(BOOL)enabled;
-- (BOOL)cssGridLayoutEnabled;
-- (void)setCSSGridLayoutEnabled:(BOOL)enabled;
-
- (BOOL)showDebugBorders;
- (void)setShowDebugBorders:(BOOL)show;
#if ENABLE(WEB_AUDIO)
settings.setWebAudioEnabled([preferences webAudioEnabled]);
#endif
- settings.setCSSGridLayoutEnabled([preferences cssGridLayoutEnabled]);
#if ENABLE(FULLSCREEN_API)
settings.setFullScreenEnabled([preferences fullScreenEnabled]);
#endif
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove cssGridLayoutEnabled setting usage.
+
+ * Shared/WebPreferencesStore.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetCSSGridLayoutEnabled): Deleted.
+ (WKPreferencesGetCSSGridLayoutEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ (webKitSettingsConstructed):
+ * UIProcess/gtk/ExperimentalFeatures.cpp:
+ * UIProcess/gtk/ExperimentalFeatures.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+ * mac/WebKit2.order:
+
2014-05-07 Csaba Osztrogonác <ossy@webkit.org>
URTBF after r168393 to fix !IOS builds.
macro(Accelerated2dCanvasEnabled, accelerated2dCanvasEnabled, Bool, bool, false) \
macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true) \
macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true) \
- macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true) \
macro(RegionBasedColumnsEnabled, regionBasedColumnsEnabled, Bool, bool, true) \
macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \
macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED) \
return toImpl(preferencesRef)->cssRegionsEnabled();
}
-void WKPreferencesSetCSSGridLayoutEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setCSSGridLayoutEnabled(flag);
-}
-
-bool WKPreferencesGetCSSGridLayoutEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->cssGridLayoutEnabled();
-}
-
void WKPreferencesSetRegionBasedColumnsEnabled(WKPreferencesRef preferencesRef, bool flag)
{
toImpl(preferencesRef)->setRegionBasedColumnsEnabled(flag);
WK_EXPORT void WKPreferencesSetCSSRegionsEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetCSSRegionsEnabled(WKPreferencesRef);
-// Defaults to false
-WK_EXPORT void WKPreferencesSetCSSGridLayoutEnabled(WKPreferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetCSSGridLayoutEnabled(WKPreferencesRef);
-
// Defaults to false
WK_EXPORT void WKPreferencesSetRegionBasedColumnsEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetRegionBasedColumnsEnabled(WKPreferencesRef);
WebPreferences* prefs = WEBKIT_SETTINGS(object)->priv->preferences.get();
ExperimentalFeatures features;
- bool cssGridLayoutEnabled = features.isEnabled(ExperimentalFeatures::CSSGridLayout);
- if (prefs->cssGridLayoutEnabled() != cssGridLayoutEnabled)
- prefs->setCSSGridLayoutEnabled(cssGridLayoutEnabled);
bool regionBasedColumnsEnabled = features.isEnabled(ExperimentalFeatures::RegionBasedColumns);
if (prefs->regionBasedColumnsEnabled() != regionBasedColumnsEnabled)
prefs->setRegionBasedColumnsEnabled(regionBasedColumnsEnabled);
};
static Setting settings[] = {
- { ExperimentalFeatures::CSSGridLayout, "CSS_GRID_LAYOUT", true },
{ ExperimentalFeatures::RegionBasedColumns, "REGION_BASED_COLUMNS", false }
};
class ExperimentalFeatures {
public:
enum Feature {
- CSSGridLayout,
RegionBasedColumns
};
#define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
macro(WebKitAcceleratedCompositingEnabled, AcceleratedCompositingEnabled, acceleratedCompositingEnabled) \
macro(WebKitCanvasUsesAcceleratedDrawing, CanvasUsesAcceleratedDrawing, canvasUsesAcceleratedDrawing) \
- macro(WebKitCSSGridLayoutEnabled, CSSGridLayoutEnabled, cssGridLayoutEnabled) \
macro(WebKitFrameFlatteningEnabled, FrameFlatteningEnabled, frameFlatteningEnabled) \
macro(WebKitJavaEnabled, JavaEnabled, javaEnabled) \
macro(WebKitJavaScriptEnabled, ScriptEnabled, javaScriptEnabled) \
settings.setTemporaryTileCohortRetentionEnabled(store.getBoolValueForKey(WebPreferencesKey::temporaryTileCohortRetentionEnabledKey()));
RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(store.getBoolValueForKey(WebPreferencesKey::cssRegionsEnabledKey()));
RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(store.getBoolValueForKey(WebPreferencesKey::cssCompositingEnabledKey()));
-#if ENABLE(CSS_GRID_LAYOUT)
- settings.setCSSGridLayoutEnabled(store.getBoolValueForKey(WebPreferencesKey::cssGridLayoutEnabledKey()));
-#endif
settings.setRegionBasedColumnsEnabled(store.getBoolValueForKey(WebPreferencesKey::regionBasedColumnsEnabledKey()));
settings.setWebGLEnabled(store.getBoolValueForKey(WebPreferencesKey::webGLEnabledKey()));
settings.setMultithreadedWebGLEnabled(store.getBoolValueForKey(WebPreferencesKey::multithreadedWebGLEnabledKey()));
__ZN6WebKit17WebPreferencesKey29accelerated2dCanvasEnabledKeyEv
__ZN6WebKit17WebPreferencesKey20cssRegionsEnabledKeyEv
__ZN6WebKit17WebPreferencesKey24cssCompositingEnabledKeyEv
-__ZN6WebKit17WebPreferencesKey23cssGridLayoutEnabledKeyEv
__ZN6WebKit17WebPreferencesKey28regionBasedColumnsEnabledKeyEv
__ZN6WebKit17WebPreferencesKey28forceFTPDirectoryListingsKeyEv
__ZN6WebKit17WebPreferencesKey14tabsToLinksKeyEv
+2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Remove runtime feature
+ https://bugs.webkit.org/show_bug.cgi?id=132382
+
+ Reviewed by Benjamin Poulain.
+
+ Remove cssGridLayoutEnabled setting usage.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+ * DumpRenderTree/efl/TestRunnerEfl.cpp:
+ (TestRunner::overridePreference):
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+
2014-05-06 David Kilzer <ddkilzer@apple.com>
Add Makefile targets for copying static libraries (LLVM and WKSI)
DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled(mainView(), true);
DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification(mainView(), -1);
DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled(mainView(), true);
- DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled(mainView(), false);
DumpRenderTreeSupportEfl::setDefersLoading(mainView(), false);
DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(mainView(), false);
DumpRenderTreeSupportEfl::setSerializeHTTPLoads(false);
ewk_view_setting_application_cache_set(browser->mainView(), toBool(value));
else if (equals(key, "WebKitLoadSiteIconsKey"))
DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(browser->mainView(), toBool(value));
- else if (equals(key, "WebKitCSSGridLayoutEnabled"))
- DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled(browser->mainView(), toBool(value));
else if (equals(key, "WebKitCSSRegionsEnabled"))
DumpRenderTreeSupportEfl::setCSSRegionsEnabled(browser->mainView(), toBool(value));
else if (equals(key, "WebKitWebAudioEnabled"))
#endif
[preferences setWebGLEnabled:NO];
[preferences setCSSRegionsEnabled:YES];
- [preferences setCSSGridLayoutEnabled:NO];
[preferences setUsePreHTML5ParserQuirks:NO];
[preferences setAsynchronousSpellCheckingEnabled:NO];
#if !PLATFORM(IOS)
git://git.webkit.org / WebKit-https.git / commitdiff