Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front...
authorcblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Oct 2004 22:05:35 +0000 (22:05 +0000)
committercblu <cblu@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Oct 2004 22:05:35 +0000 (22:05 +0000)
        Reviewed by darin.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQKHTMLPart.mm

index 6f867b84b60d661d7b158c03d8a980b7029172fc..df7c094d80395bdf5a9d677212b6c4fb0611dd5d 100644 (file)
@@ -1,3 +1,12 @@
+2004-10-28  Chris Blumenberg  <cblu@apple.com>
+
+       Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front page of store.apple.com
+
+        Reviewed by darin.
+
+        * kwq/KWQKHTMLPart.mm:
+        (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it
+
 2004-10-28  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by Harrison
index 9ec7ca550b58d40dc2f643e854375a59f6c07824..492f6dc10800094a91ca24615c3af99cadb39f31 100644 (file)
@@ -3043,7 +3043,7 @@ NSAttributedString *KWQKHTMLPart::attributedString(NodeImpl *_start, int startOf
                             listItemLocations.append (info);
                             
                             listText += '\t';
-                            if (itemParent){
+                            if (itemParent && renderer->isListItem()) {
                                 RenderListItem *listRenderer = static_cast<RenderListItem*>(renderer);
 
                                 maxMarkerWidth = MAX([font pointSize], maxMarkerWidth);