Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
        ghostmap XHTML + SVG fails due to javascript undefined exception

        Make sure document.URL works when called from a non-HTML document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index c31716b..c288cde 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2006-07-29  Rob Buis  <buis@kde.org>
+
+        Reviewed by Geoff.
+
+        Updated test case result as a result of:
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
+        ghostmap XHTML + SVG fails due to javascript undefined exception
+        The new test case result now should match the required spec result
+        and acts as a way to test document.URL on non-html documents.
+
+        * dom/xhtml/level2/html/HTMLDocument04-expected.txt:
+
 2006-07-29  Darin Adler  <darin@apple.com>
 
         - changed this test to a plain-text one and added text explaining what it tests

diff --git a/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt b/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt
index 44305e1..c2664e5 100644 (file)
--- a/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt
+++ b/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt
@@ -1,4 +1,4 @@
+ALERT: file:///Users/rwlbuis/svn/test/WebKit/LayoutTests/dom/xhtml/level2/html/HTMLDocument04.xhtml
 Test   http://www.w3.org/2001/DOM-Test-Suite/level2/html/HTMLDocument04
-Status failure
-Message        URLLink: assertNotNull failed
+Status Success
 

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index cb3bd97..5bf5680 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2006-07-29  Rob Buis  <buis@kde.org>
+
+        Reviewed by Geoff.
+
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
+        ghostmap XHTML + SVG fails due to javascript undefined exception
+
+        Make sure document.URL works when called from a non-HTML document.
+
+        * bindings/js/kjs_html.cpp:
+        (KJS::JSHTMLDocument::getValueProperty):
+        * bindings/js/kjs_html.h:
+        (KJS::JSHTMLDocument::):
+        * dom/Document.idl:
+
 2006-07-29  Mike Emmel  <mike.emmel@gmail.com>
 
         Reviewed and tweaked by Darin.

diff --git a/WebCore/bindings/js/kjs_html.cpp b/WebCore/bindings/js/kjs_html.cpp
index 617d08c..1e5d0fe 100644 (file)
--- a/WebCore/bindings/js/kjs_html.cpp
+++ b/WebCore/bindings/js/kjs_html.cpp
@@ -174,7 +174,6 @@ const ClassInfo JSHTMLDocument::info =
   title                 JSHTMLDocument::Title             DontDelete
   referrer              JSHTMLDocument::Referrer          DontDelete|ReadOnly
   domain                JSHTMLDocument::Domain            DontDelete
-  URL                   JSHTMLDocument::URL               DontDelete|ReadOnly
   body                  JSHTMLDocument::Body              DontDelete
   location              JSHTMLDocument::Location          DontDelete
   cookie                JSHTMLDocument::Cookie            DontDelete
@@ -249,8 +248,6 @@ JSValue *JSHTMLDocument::getValueProperty(ExecState* exec, int token) const
     return jsString(doc.referrer());
   case Domain:
     return jsString(doc.domain());
-  case URL:
-    return jsString(doc.URL());
   case Body:
     return toJS(exec, body);
   case Location:

diff --git a/WebCore/bindings/js/kjs_html.h b/WebCore/bindings/js/kjs_html.h
index 5258540..1863e68 100644 (file)
--- a/WebCore/bindings/js/kjs_html.h
+++ b/WebCore/bindings/js/kjs_html.h
@@ -51,7 +51,7 @@ namespace KJS {
     void putValueProperty(ExecState*, int token, JSValue*, int /*attr*/);
     virtual const ClassInfo* classInfo() const { return &info; }
     static const ClassInfo info;
-    enum { Title, Referrer, Domain, URL, Body, Location, Cookie,
+    enum { Title, Referrer, Domain, Body, Location, Cookie,
            Images, Applets, Embeds, Links, Forms, Anchors, Scripts, All, Clear, Open, Close,
            Write, WriteLn, GetElementsByName, CaptureEvents, ReleaseEvents,
            BgColor, FgColor, AlinkColor, LinkColor, VlinkColor, LastModified, Height, Width, Dir, DesignMode };

diff --git a/WebCore/dom/Document.idl b/WebCore/dom/Document.idl
index 9381b9e..bbd20e3 100644 (file)
--- a/WebCore/dom/Document.idl
+++ b/WebCore/dom/Document.idl
@@ -148,6 +148,8 @@ module core {
 
         // IE extensions
 
+        readonly attribute DOMString URL;
+
         attribute [ConvertNullStringTo=Undefined] DOMString charset;
 
         readonly attribute [ConvertNullStringTo=Undefined] DOMString defaultCharset;