WebKitTools:
authorweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Nov 2007 01:33:49 +0000 (01:33 +0000)
committerweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Nov 2007 01:33:49 +0000 (01:33 +0000)
        Reviewed by Adam Roben.

        Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setPrivateBrowsingEnabled):

LayoutTests:

        Reviewed by Adam Roben.

        * platform/win/Skipped: Remove http/tests/security/cross-frame-acdcess-private-browsing.html
        from the windows skipped list now that LayoutTestController.setPrivateBrowsingEnabled has
        been implmented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

index df2d6abe488e7bee8d16d551e21b1e24e2a82523..867549c2052196226294e1f940657a6628c4bedd 100644 (file)
@@ -1,3 +1,11 @@
+2007-11-12  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        * platform/win/Skipped: Remove http/tests/security/cross-frame-acdcess-private-browsing.html 
+        from the windows skipped list now that LayoutTestController.setPrivateBrowsingEnabled has 
+        been implmented.
+
 2007-11-12  Darin Adler  <darin@apple.com>
 
         Reviewed by Sam.
index 6442c94c432051405171bb208e1e241724683bfe..ff8b7e918b5435dbb05e4708ff9971c9c9128eaf 100644 (file)
@@ -610,6 +610,3 @@ svg/custom/gradient-stop-style-change.svg
 
 # <video> support
 media
-
-# add support for layoutTestController.setPrivateBrowsingEnabled(bool)
-http/tests/security/cross-frame-access-private-browsing.html
index 3067d7c53481ad6e8b6a06df56605da815ccb5d2..020e17f94166fd14a0d46cd0c7f1d7631bf37a92 100644 (file)
@@ -1,3 +1,14 @@
+2007-11-12  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (runTest):
+        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
+        (LayoutTestController::setPrivateBrowsingEnabled):
+
 2007-11-12  Adam Roben  <aroben@apple.com>
 
         * Scripts/update-webkit-localizable-strings: Changed to only scan the
index 49d3bb7db2d0ed22ddf179484871d6a7944a0994..df7efb3e08e7e11b8b2b73066174e6b343b60203 100644 (file)
@@ -618,6 +618,10 @@ static void runTest(const char* pathOrURL)
         COMPtr<IWebIBActions> webIBActions;
         if (SUCCEEDED(webView->QueryInterface(IID_IWebIBActions, (void**)&webIBActions)))
             webIBActions->makeTextStandardSize(0);
+
+        COMPtr<IWebPreferences> preferences;
+        if (SUCCEEDED(webView->preferences(&preferences)))
+            preferences->setPrivateBrowsingEnabled(FALSE);
     }
 
     WorkQueue::shared()->clear();
index d4187c5372694b93d363648d781a65b13623bec3..cf059775af6dedd0c64a25b3c06eaf67f248ba85 100644 (file)
@@ -236,9 +236,17 @@ void LayoutTestController::setMainFrameIsFirstResponder(bool flag)
     // FIXME: Implement!
 }
 
-void LayoutTestController::setPrivateBrowsingEnabled(bool /*privateBrowsingEnabled*/)
+void LayoutTestController::setPrivateBrowsingEnabled(bool privateBrowsingEnabled)
 {
-    // FIXME: Implement!
+    COMPtr<IWebView> webView;
+    if (FAILED(frame->webView(&webView)))
+        return;
+
+    COMPtr<IWebPreferences> preferences;
+    if (FAILED(webView->preferences(&preferences)))
+        return;
+
+    preferences->setPrivateBrowsingEnabled(privateBrowsingEnabled);
 }
 
 void LayoutTestController::setTabKeyCyclesThroughElements(bool shouldCycle)