2006-03-05 Eric Seidel <eseidel@apple.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Mar 2006 07:18:42 +0000 (07:18 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Mar 2006 07:18:42 +0000 (07:18 +0000)
        Reviewed by darin.

        Make updateContents invalidate entire window for now.
        Fix indentation in fileLoadTimer.

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateContents):
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/win/ScrollViewWin.cpp
WebCore/platform/win/TransferJobWin.cpp

index fd50c261aa8fa0634f1d88373741015587edc5c8..80d5c3c55646ee0c7cdb9c520f255b2629ab3126 100644 (file)
@@ -1,3 +1,15 @@
+2006-03-05  Eric Seidel  <eseidel@apple.com>
+
+        Reviewed by darin.
+
+        Make updateContents invalidate entire window for now.
+        Fix indentation in fileLoadTimer.
+
+        * platform/win/ScrollViewWin.cpp:
+        (WebCore::ScrollView::updateContents):
+        * platform/win/TransferJobWin.cpp:
+        (WebCore::TransferJob::fileLoadTimer):
+
 2006-03-05  Eric Seidel  <eseidel@apple.com>
 
         Reviewed by adele.
index f5eaf98ee83903b61e6543a731ea49ac5ecf7881..00c2ef4eb5a9102e8308c9ff2d04f3c82e05020e 100644 (file)
 
 namespace WebCore {
 
-void ScrollView::updateContents(const IntRect& dirtyRect, bool now)
+void ScrollView::updateContents(const IntRect&, bool now)
 {
-    RECT repaintRect = RECT(dirtyRect);
-    InvalidateRect(windowHandle(), &repaintRect, true);
+    // FIXME: Too many other things are broken to turn on precise invalidation
+    InvalidateRect(windowHandle(), 0, true);
     if (now)
         UpdateWindow(windowHandle());
 }
index a76f093b4475a7685a3e32f17f766f53519d6e9a..194315c9cf24e45594facdc7529a39da34294ece 100644 (file)
@@ -34,8 +34,8 @@ namespace WebCore {
     
 TransferJobInternal::~TransferJobInternal()
 {
-       if (m_fileHandle)
-               CloseHandle(m_fileHandle);
+    if (m_fileHandle)
+        CloseHandle(m_fileHandle);
 }
 
 TransferJob::~TransferJob()
@@ -48,13 +48,13 @@ bool TransferJob::start(DocLoader* docLoader)
         QString path = d->URL.path();
         // windows does not enjoy a leading slash on paths
         if (path[0] == '/')
-               path = path.mid(1);
-           d->m_fileHandle = CreateFileA(path.ascii(), GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+            path = path.mid(1);
+        d->m_fileHandle = CreateFileA(path.ascii(), GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
     }
 
     if (!d->m_fileHandle || d->m_fileHandle == INVALID_HANDLE_VALUE) {
         delete this;
-       return false;
+        return false;
     }
 
     d->m_fileLoadTimer.startOneShot(0.0);
@@ -68,10 +68,10 @@ void TransferJob::fileLoadTimer(Timer<TransferJob>* timer)
 
     do {
         const int bufferSize = 8192;
-       char buffer[bufferSize];
-       result = ReadFile(d->m_fileHandle, &buffer, bufferSize, &bytesRead, NULL); 
-       d->client->receivedData(this, buffer, bytesRead);
-       // Check for end of file. 
+        char buffer[bufferSize];
+        result = ReadFile(d->m_fileHandle, &buffer, bufferSize, &bytesRead, NULL); 
+        d->client->receivedData(this, buffer, bytesRead);
+        // Check for end of file. 
     } while (result && bytesRead);
 
     CloseHandle(d->m_fileHandle);