+2015-01-21 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
+ https://bugs.webkit.org/show_bug.cgi?id=140746
+
+ Reviewed by Timothy Hatcher.
+
+ * TestExpectations:
+ Unskip the test now that is doesn't ASSERT in debug builds.
+
2015-01-21 Daniel Bates <dabates@apple.com>
Update iOS WebKit2 expected results for compositing tests
+2015-01-21 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
+ https://bugs.webkit.org/show_bug.cgi?id=140746
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InjectedScriptSource.js:
+ Do not add impure properties to the descriptor object that will
+ eventually be sent to the frontend.
+
2015-01-21 Matthew Mirman <mmirman@apple.com>
Updated split such that it does not include the empty end of input string match.
function createFakeValueDescriptor(name, descriptor, isOwnProperty)
{
try {
- return {name: name, value: object[name], writable: descriptor.writable, configurable: descriptor.configurable, enumerable: descriptor.enumerable};
+ return {name: name, value: object[name], writable: descriptor.writable || false, configurable: descriptor.configurable || false, enumerable: descriptor.enumerable || false};
} catch (e) {
var errorDescriptor = {name: name, value: e, wasThrown: true};
if (isOwnProperty)
}
}
- function processDescriptor(descriptor, isOwnProperty)
+ function processDescriptor(descriptor, isOwnProperty, possibleNativeBindingGetter)
{
// Own properties only.
if (ownProperties) {
} else if (descriptor.hasOwnProperty("get") && descriptor.get) {
// Getter property in the prototype chain. Create a fake value descriptor.
descriptors.push(createFakeValueDescriptor(descriptor.name, descriptor, isOwnProperty));
- } else if (descriptor.possibleNativeBindingGetter) {
+ } else if (possibleNativeBindingGetter) {
// Possible getter property in the prototype chain.
descriptors.push(descriptor);
}
// Developers may create such a descriptors, so we should be resilient:
// var x = {}; Object.defineProperty(x, "p", {get:undefined}); Object.getOwnPropertyDescriptor(x, "p")
var fakeDescriptor = createFakeValueDescriptor(name, descriptor, isOwnProperty);
- fakeDescriptor.possibleNativeBindingGetter = true; // Native bindings.
- processDescriptor(fakeDescriptor, isOwnProperty);
+ processDescriptor(fakeDescriptor, isOwnProperty, true);
continue;
}