2011-02-06 Robert Hogan <robert@webkit.org>
authorrobert@webkit.org <robert@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 6 Feb 2011 18:18:35 +0000 (18:18 +0000)
committerrobert@webkit.org <robert@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 6 Feb 2011 18:18:35 +0000 (18:18 +0000)
        Reviewed by Andreas Kling.

        [Qt] Clear page's groupName even when not in DRT
        https://bugs.webkit.org/show_bug.cgi?id=53874

        Matches behaviour of other ports.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::closeWindowSoon):
2011-02-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Clear page's groupName even when not in DRT
        https://bugs.webkit.org/show_bug.cgi?id=53874

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::windowCloseRequested):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
Tools/ChangeLog
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

index 955e1e1cb6ea5e1fde7dbe7c75bc1d1fcbfad94d..b13c1ea3d8a9f78e0bc2cc2697c19441277e6b39 100644 (file)
@@ -1,3 +1,15 @@
+2011-02-06  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Clear page's groupName even when not in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=53874
+
+        Matches behaviour of other ports.
+
+        * WebCoreSupport/ChromeClientQt.cpp:
+        (WebCore::ChromeClientQt::closeWindowSoon):
+
 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
 
         Reviewed by Pavel Feldman.
index 5a51b63e3161b9eadc89471e618923368fba8b77..b7a03501500dd515352f37a4665e7e621f026606 100644 (file)
@@ -307,6 +307,7 @@ bool ChromeClientQt::runBeforeUnloadConfirmPanel(const String& message, Frame* f
 
 void ChromeClientQt::closeWindowSoon()
 {
+    m_webPage->d->page->setGroupName(String());
     m_webPage->mainFrame()->d->frame->loader()->stopAllLoaders();
     emit m_webPage->windowCloseRequested();
 }
index 5ca2904669b5c118f39cd48e4494c5726b8d96c0..a761dc790115d4b4b304f4906a60d8fdb6cd2e9c 100644 (file)
@@ -1,3 +1,13 @@
+2011-02-06  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Clear page's groupName even when not in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=53874
+
+        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+        (WebCore::DumpRenderTree::windowCloseRequested):
+
 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
 
         Reviewed by Andreas Kling.
index ac5d9e74bebe6883fe8a2e414e128b33b3d5957c..b27a426f092f611197d77b1d2d110be8cdf5049c 100644 (file)
@@ -1084,9 +1084,6 @@ void DumpRenderTree::windowCloseRequested()
     QWebPage* page = qobject_cast<QWebPage*>(sender());
     QObject* container = page->parent();
     windows.removeAll(container);
-    // Our use of container->deleteLater() means we need to remove closed pages
-    // from the org.webkit.qt.DumpRenderTree group explicitly.
-    DumpRenderTreeSupportQt::webPageSetGroupName(page, "");
     container->deleteLater();
 }