2007-09-27 Mitz Pettel <mitz@webkit.org>
authorbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Sep 2007 01:01:42 +0000 (01:01 +0000)
committerbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Sep 2007 01:01:42 +0000 (01:01 +0000)
        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15262
          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.

        Reflected in existing tests.

        * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox,
        WinIE and apparently also Safari 2.

2007-09-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=15262
          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.

        * fast/forms/listbox-clip-expected.checksum:
        * fast/forms/listbox-clip-expected.png:
        * fast/forms/listbox-clip-expected.txt:
        * fast/forms/listbox-selection-2.html:
        * fast/forms/select-item-background-clip.html:
        * fast/forms/select-list-box-with-height-expected.checksum:
        * fast/forms/select-list-box-with-height-expected.png:
        * fast/forms/select-list-box-with-height-expected.txt:
        * fast/text/drawBidiText.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/listbox-clip-expected.checksum
LayoutTests/fast/forms/listbox-clip-expected.png
LayoutTests/fast/forms/listbox-clip-expected.txt
LayoutTests/fast/forms/listbox-selection-2.html
LayoutTests/fast/forms/select-item-background-clip.html
LayoutTests/fast/forms/select-list-box-with-height-expected.checksum
LayoutTests/fast/forms/select-list-box-with-height-expected.png
LayoutTests/fast/forms/select-list-box-with-height-expected.txt
LayoutTests/fast/text/drawBidiText.html
WebCore/ChangeLog
WebCore/css/html4.css

index 7dff558042717dbf04566aa73962cc6ca81e0ea6..8463135ac7d558342aadaa1dc50db65feaeb759e 100644 (file)
@@ -1,3 +1,20 @@
+2007-09-27  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=15262
+          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.
+
+        * fast/forms/listbox-clip-expected.checksum:
+        * fast/forms/listbox-clip-expected.png:
+        * fast/forms/listbox-clip-expected.txt:
+        * fast/forms/listbox-selection-2.html:
+        * fast/forms/select-item-background-clip.html:
+        * fast/forms/select-list-box-with-height-expected.checksum:
+        * fast/forms/select-list-box-with-height-expected.png:
+        * fast/forms/select-list-box-with-height-expected.txt:
+        * fast/text/drawBidiText.html:
+
 2007-09-27  Antti Koivisto  <antti@apple.com>
 
         Reviewed by Geoff.
index f443e855f8b71b70451cd2273cc0f2d3e6c5e6ea..4e73b56077bfe1f3c85cde77a1732af6376c8d36 100644 (file)
@@ -1 +1 @@
-244469ce5e8f5b033c6d73c7b7fd13d3
\ No newline at end of file
+c8dfb9f2896f50dc201a942d722b4067
\ No newline at end of file
index 6b2a53d8ee6e4accef7ff58898dd2fe3020875a1..c81d13b98819eccfd631a9c7433a59f8504d16eb 100644 (file)
Binary files a/LayoutTests/fast/forms/listbox-clip-expected.png and b/LayoutTests/fast/forms/listbox-clip-expected.png differ
index 8d26e5f966aa24ae6766924a8cb0030a28b58f01..86e632a080efeda036b2590caeaec7aa9cfdcb0c 100644 (file)
@@ -3,7 +3,7 @@ layer at (0,0) size 800x600
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
     RenderBody {BODY} at (8,8) size 784x584
-      RenderListBox {SELECT} at (0,2) size 102x106 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
+      RenderListBox {SELECT} at (0,2) size 100x106 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
       RenderText {#text} at (0,0) size 0x0
index c15f4c8a3df6b9e82612dcef1437655ef37af9a8..7f88bf558648dca1c185f703cf2dd6bd651cf467 100644 (file)
@@ -93,7 +93,7 @@
     </head>
     <body onload="test()">
 
-    <select id="sl1" multiple style="height: 105px; border: 10px solid; padding: 5px;">
+    <select id="sl1" multiple style="height: 135px; border: 10px solid; padding: 5px;">
         <option>one</option>
         <option>two</option>
         <option>three</option>
         <option>seventeen</option>
     </select>
     
-    <select id="sl2" multiple style="height: 105px; border: 10px solid; padding: 5px;">
+    <select id="sl2" multiple style="height: 135px; border: 10px solid; padding: 5px;">
         <option>one</option>
         <option>two</option>
         <option>three</option>
index 884abfd2218927c841be6c9ea1adf7b2c44018c0..8c61c1ec0fa189449e87968173e5877a572b00a7 100644 (file)
@@ -7,7 +7,7 @@
         Test for <i><a href="http://bugs.webkit.org/show_bug.cgi?id=12364">http://bugs.webkit.org/show_bug.cgi?id=12364</a>
         REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box</i>.
     </p>
-    <select size="4" style="height: 46px; border: 3px solid blue; padding: 3px;">
+    <select size="4" style="height: 58px; border: 3px solid blue; padding: 3px;">
         <option>one</option>
         <option>two</option>
         <option>three</option>
index f1ccb8d12827caa96e680270069585eeca934574..f7e75347e00a5ae107ca8be45f4502afd388212c 100644 (file)
@@ -1 +1 @@
-1c8f99de59c167828bd8b3f3080dd11c
\ No newline at end of file
+945ca1438a48ec64890c56ec37ff024f
\ No newline at end of file
index 6b00bcf674327734a06f311d759cb4b85ea870c7..699e82a8768238817e8cda2c4cc59d7894e169ae 100644 (file)
Binary files a/LayoutTests/fast/forms/select-list-box-with-height-expected.png and b/LayoutTests/fast/forms/select-list-box-with-height-expected.png differ
index 168a6f455683d8a754d1c0ae1e2cd51f07125e20..dd602c268c71996433e3eac963c2408a92e9dc3d 100644 (file)
@@ -6,6 +6,6 @@ layer at (0,0) size 800x600
       RenderBlock {P} at (0,0) size 784x18
         RenderText {#text} at (0,0) size 365x18
           text run at (0,0) width 365: "The select below has a size of 3, but a much larger height."
-      RenderBlock (anonymous) at (0,34) size 784x252
-        RenderListBox {SELECT} at (2,0) size 59x252 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
+      RenderBlock (anonymous) at (0,34) size 784x250
+        RenderListBox {SELECT} at (2,0) size 59x250 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
         RenderText {#text} at (0,0) size 0x0
index 4a89769e8cbb3af22212ad29844deb0d8f317e87..9df1495c0d5ba1b0cfc26be21fa73cdd366a77b5 100644 (file)
Binary files a/LayoutTests/fast/text/drawBidiText.html and b/LayoutTests/fast/text/drawBidiText.html differ
index 9e8abbb7f3e173b9cf6077ac4d3673a72c9e94b4..824a536af6518ec4a235dc0f7553fc7370244fd6 100644 (file)
@@ -1,3 +1,15 @@
+2007-09-27  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15262
+          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.
+
+        Reflected in existing tests.
+
+        * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox,
+        WinIE and apparently also Safari 2.
+
 2007-09-27  Kevin Decker  <kdecker@apple.com>
 
         <rdar://problem/5493093>
index 0c6c63770b3f74e78441c0d84c30c452ce46c57b..566466e5d5a1cd7a950fdac261e10289cbda1947 100644 (file)
@@ -459,7 +459,6 @@ select[size],
 select[multiple],
 select[size][multiple] {
     -webkit-appearance: listbox;
-    -webkit-box-sizing: initial;
     -webkit-box-align: start;
     border: 1px inset gray;
     -webkit-border-radius: initial;
@@ -469,7 +468,6 @@ select[size][multiple] {
 select[size="0"],
 select[size="1"] {
     -webkit-appearance: menulist;
-    -webkit-box-sizing: border-box;
     -webkit-box-align: center;
     border: 1px solid;
     -webkit-border-radius: 5px;