REGRESSION: xssAuditor tests failing in Chromium.
authorjparent@chromium.org <jparent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 23 May 2010 06:45:08 +0000 (06:45 +0000)
committerjparent@chromium.org <jparent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 23 May 2010 06:45:08 +0000 (06:45 +0000)
https://bugs.webkit.org/show_bug.cgi?id=39560

Reviewed by Adam Barth.

Follow up to r0014. Make if statement in V8 bindings match the one from jsc version.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bindings/v8/ScriptController.cpp

index 4d6820fe47d88fac242ee9b23a2c130de080d993..b39a9a111153cf2b74a0a902f0f17fb313117a13 100644 (file)
@@ -1,3 +1,15 @@
+2010-05-22  Julie Parent  <jparent@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        REGRESSION: xssAuditor tests failing in Chromium.
+        https://bugs.webkit.org/show_bug.cgi?id=39560
+
+        Follow up to r0014. Make if statement in V8 bindings match the one from jsc version.
+
+        * bindings/v8/ScriptController.cpp:
+        (WebCore::ScriptController::evaluate):
+
 2010-05-22  Maciej Stachowiak  <mjs@apple.com>
 
         Reviewed by Mark Rowe.
index 71407c2a1a50cd47afc6065a82254debad72bd49..3bc9837d609d56fad5acc98edeb2fdfbd03d61a5 100644 (file)
@@ -230,7 +230,7 @@ ScriptValue ScriptController::evaluate(const ScriptSourceCode& sourceCode, Shoul
     const String* savedSourceURL = m_sourceURL;
     m_sourceURL = &sourceURL;
 
-    if (!shouldAllowXSS && !m_XSSAuditor->canEvaluate(sourceCode.source())) {
+    if (shouldAllowXSS == DoNotAllowXSS && !m_XSSAuditor->canEvaluate(sourceCode.source())) {
         // This script is not safe to be evaluated.
         return ScriptValue();
     }