Build fix. It looks like the code here is racy.
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jul 2017 02:38:03 +0000 (02:38 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 Jul 2017 02:38:03 +0000 (02:38 +0000)
* public/v3/components/chart-pane-base.js:
(ChartPaneBase.prototype.configure):
(ChartPaneBase.prototype.setOpenRepository):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/components/chart-pane-base.js

index 37d9b4acd80bb049294854d0495b8ddbd00c2362..4fda6081afbd4c2b00c7ba953af117a9158718d1 100644 (file)
@@ -1,3 +1,11 @@
+2017-07-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Build fix. It looks like the code here is racy.
+
+        * public/v3/components/chart-pane-base.js:
+        (ChartPaneBase.prototype.configure):
+        (ChartPaneBase.prototype.setOpenRepository):
+
 2017-07-11  Ryosuke Niwa  <rniwa@webkit.org>
 
         Show the roots built by perf try bots on results page
index 95662c4badef1c0f9fa2de62bc49ad8f1f70b016..574f029f0a49f89fe409ec62b55130203d064399 100644 (file)
@@ -57,6 +57,7 @@ class ChartPaneBase extends ComponentBase {
         this._revisionRange = new ChartRevisionRange(this._mainChart);
 
         this._mainChartStatus = new ChartPaneStatusView(result.metric, this._mainChart);
+        this._mainChartStatus.setCurrentRepository(this._openRepository);
         this._mainChartStatus.listenToAction('openRepository', this.openNewRepository.bind(this));
         this.renderReplace(this.content().querySelector('.chart-pane-details'), this._mainChartStatus);
 
@@ -132,7 +133,8 @@ class ChartPaneBase extends ComponentBase {
     setOpenRepository(repository)
     {
         this._openRepository = repository;
-        this._mainChartStatus.setCurrentRepository(repository);
+        if (this._mainChartStatus)
+            this._mainChartStatus.setCurrentRepository(repository);
         this._updateCommitLogViewer();
     }