Patch contributed by Joos de Valk <webkit@joostdevalk.nl>.
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 Jun 2005 18:14:27 +0000 (18:14 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 Jun 2005 18:14:27 +0000 (18:14 +0000)
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408
        Reviewed by Darin.

        Test cases added: None. Test requires manual interaction.
Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207

        * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
        * khtml/html/html_formimpl.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog-2005-08-23
WebCore/khtml/html/html_formimpl.cpp
WebCore/khtml/html/html_formimpl.h

index ad431208f60e51c8bc17aa55b8e0c895a0a009d4..d3ae42bac25e9dffd028dc4fec94f1003934d2fd 100644 (file)
@@ -1,3 +1,17 @@
+2005-06-17  Geoffrey Garen  <ggaren@apple.com>
+
+       Patch contributed by Joos de Valk <webkit@joostdevalk.nl>.
+
+       Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=3408      
+
+        Reviewed by Darin.
+
+        Test cases added: None. Test requires manual interaction.
+       Manual test available at: http://bugzilla.opendarwin.org/attachment.cgi?id=2207
+
+        * khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click. 
+        * khtml/html/html_formimpl.h: Ditto.
+
 2005-06-17  Darin Adler  <darin@apple.com>
 
         Reviewed by John.
index b701f6ff5674276581d4fe55ca223d3b1d9609de..35afbf613cb71a99f81edb4e796842d5667f3a23 100644 (file)
@@ -1267,19 +1267,6 @@ bool HTMLButtonElementImpl::appendFormData(FormDataList& encoding, bool /*multip
     return true;
 }
 
-void HTMLButtonElementImpl::click(bool sendMouseEvents)
-{
-#if APPLE_CHANGES
-    QWidget *widget;
-    if (renderer() && (widget = static_cast<RenderWidget *>(renderer())->widget())) {
-        // using this method gives us nice Cocoa user interface feedback
-        static_cast<QButton *>(widget)->click(sendMouseEvents);
-    }
-    else
-#endif
-        HTMLGenericFormElementImpl::click(sendMouseEvents);
-}
-
 void HTMLButtonElementImpl::accessKeyAction(bool sendToAnyElement)
 {   
     // send the mouse button events iff the
index 875345726640bb9786d9ec486c8d2119a5e1a0f8..f66e990ef5e8d5d81ce9ae6732e0bd832c544eee 100644 (file)
@@ -253,7 +253,6 @@ public:
     virtual bool isActivatedSubmit() const;
     virtual void setActivatedSubmit(bool flag);
 
-    virtual void click(bool sendMouseEvents);
     virtual void accessKeyAction(bool sendToAnyElement);
 
     DOMString accessKey() const;