REGRESSION (r170576): Storage leaks in parsing of CSS image sizes

https://bugs.webkit.org/show_bug.cgi?id=141026

Reviewed by Brent Fulgham.

Forgot to actually fix the leak in the successful parse case!

* css/CSSParser.cpp:
(WebCore::CSSParser::sourceSize): Added a call to destroy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 8a7af499f43296a1593147360cb564e69e0482a8..7649bb05fc403421406f8d3f8f4a77b8785025dd 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2015-02-02  Darin Adler  <darin@apple.com>
+
+        REGRESSION (r170576): Storage leaks in parsing of CSS image sizes
+        https://bugs.webkit.org/show_bug.cgi?id=141026
+
+        Reviewed by Brent Fulgham.
+
+        Forgot to actually fix the leak in the successful parse case!
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::sourceSize): Added a call to destroy.
+
 2015-02-02  Benjamin Poulain  <benjamin@webkit.org>
 
         JIT Compile simple cases of :nth-last-child()

diff --git a/Source/WebCore/css/CSSParser.cpp b/Source/WebCore/css/CSSParser.cpp
index 6fd6383494f046f8123706263409d125122c4979..759bcb6cf888bccb82b009e39883ef19f6c53863 100644 (file)
--- a/Source/WebCore/css/CSSParser.cpp
+++ b/Source/WebCore/css/CSSParser.cpp
@@ -1523,8 +1523,9 @@ CSSParser::SourceSize CSSParser::sourceSize(std::unique_ptr<MediaQueryExp>&& exp
     }
     if (!value)
         value = parserValue.createCSSValue();
+    destroy(parserValue);
     // FIXME: Calling the constructor explicitly here to work around an MSVC bug.
-    // With the other compilers, this works without explicitly stating the type name SourceSize or using a local.
+    // For other compilers, we did not need to define the constructors and we could use aggregate initialization syntax.
     return SourceSize(WTF::move(expression), WTF::move(value));
 }